Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparator Errors #2669

Closed
mpalat opened this issue Jul 4, 2024 · 3 comments
Closed

Comparator Errors #2669

mpalat opened this issue Jul 4, 2024 · 3 comments
Assignees

Comments

@mpalat
Copy link
Contributor

mpalat commented Jul 4, 2024

From @MohananRahul - raised against platform releng -eclipse-platform/eclipse.platform.releng.aggregator#2163 found to be jdt.core issue - raising here:

Comparator Error found :
https://download.eclipse.org/eclipse/downloads/drops4/I20240703-1800/buildlogs/comparatorlogs/buildtimeComparatorUnanticipated.log.txt

eclipse.jdt.core/org.eclipse.jdt.core.tests.performance/pom.xml
no-classifier: different
org/eclipse/jdt/core/tests/performance/FullSourceWorkspaceBuildTests.class: different
The main artifact has been replaced with the baseline version.
The following attached artifacts have been replaced with the baseline version: [sources]

image

@mpalat
Copy link
Contributor Author

mpalat commented Jul 4, 2024

The issue is in FullSourceWorkspaceBuildTests.scanfile() - this is due to a value change of TerminalTokens.TokenNameEOF which is used in case statements - specifically this change - bf0427a#diff-defeff8a2b5cf674526eec934a508f1a52858f20678cf9631de32d006d35a8c9

An update of baseline would be the right way

@srikanth-sankaran
Copy link
Contributor

@mpalat Should this be open anymore ??

@MohananRahul
Copy link
Contributor

@srikanth-sankaran issue resolved , please close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants