Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-batch-compiler move cleanup (#181) #578

Merged
merged 5 commits into from
Dec 2, 2022

Conversation

iloveeclipse
Copy link
Member

@iloveeclipse iloveeclipse commented Dec 2, 2022

Moved grammar and parser generation scripts to batch compiler

  • Grammar file belongs to compiler, build scripts for it too.
  • Added grammar to sources.

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=562044 for original contribution motivation for parser build scripts. No idea if the code still works and no idea where to get the right native JikesPG executable, so I can't test if that works or not.

Removed ancient build scripts related to batch compiler

Cleaning up org.eclipse.jdt.core and trying to sort out old unused
scripts from still used but requiring an update after move.

  • Removed obsoleted "batch" and "compiler" build references
  • Removed obsoleted main-class attribute from jdt.core manifest

jdt.core can't be used anymore as self containing Java compiler library, it is now org.eclipse.jdt.core.compiler.batch.

Add moved classes located now in org.eclipse.jdt.core.compiler.batch to the jdtCompilerAdapter.jar used by pde.build & Ant (see org.eclipse.ant.internal.ui.datatransfer.BuildFileCreator).

See
eclipse-pde/eclipse.pde#419
#181

…e-jdt#181)

- Grammar file belongs to compiler, build scripts for it too.
- Added grammar to sources.

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=562044 for original
contribution motivation for parser build scripts. No idea if the code
still works and no idea where to get the *right* native JikesPG
executable, so I can't test if that works or not.

See eclipse-jdt#181
)

Cleaning up org.eclipse.jdt.core and trying to sort out old unused
scripts from still used but requiring an update after move.

See eclipse-jdt#181
…e-jdt#181)

jdt.core can't be used anymore as self containing Java compiler library,
it is now org.eclipse.jdt.core.compiler.batch.

See eclipse-jdt#181
…t#181)

Add moved classes located now in org.eclipse.jdt.core.compiler.batch to
the jdtCompilerAdapter.jar used by pde.build & Ant (see
org.eclipse.ant.internal.ui.datatransfer.BuildFileCreator).

See
eclipse-pde/eclipse.pde#419
eclipse-jdt#181
@iloveeclipse iloveeclipse merged commit 9a7efa6 into eclipse-jdt:master Dec 2, 2022
@iloveeclipse iloveeclipse deleted the pde_issue_419 branch December 2, 2022 18:20
@iloveeclipse iloveeclipse changed the title Fix jdtCompilerAdapter.jar generation for pde/ant support (#181) Post-batch-compiler move cleanup (#181) Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant