Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post-batch-compiler move cleanup (#181) #577

Closed
wants to merge 4 commits into from
Closed

Post-batch-compiler move cleanup (#181) #577

wants to merge 4 commits into from

Conversation

iloveeclipse
Copy link
Member

@iloveeclipse iloveeclipse commented Dec 2, 2022 •
edited
Loading

Moved grammar and parser generation scripts to batch compiler

  • Grammar file belongs to compiler, build scripts for it too.
  • Added grammar to sources.

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=562044 for original contribution motivation for parser build scripts. No idea if the code still works and no idea where to get the right native JikesPG executable, so I can't test if that works or not.

Removed ancient build scripts related to batch compiler

Cleaning up org.eclipse.jdt.core and trying to sort out old unused
scripts from still used but requiring an update after move.

  • Removed obsoleted "batch" and "compiler" build references
  • Removed obsoleted main-class attribute from jdt.core manifest

jdt.core can't be used anymore as self containing Java compiler library, it is now org.eclipse.jdt.core.compiler.batch.

See #181

@iloveeclipse
Moved grammar and parser generation scripts to batch compiler (eclips…
89c7b30 
…e-jdt#181)

- Grammar file belongs to compiler, build scripts for it too.
- Added grammar to sources.

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=562044 for original
contribution motivation for parser build scripts. No idea if the code
still works and no idea where to get the *right* native JikesPG
executable, so I can't test if that works or not.

See eclipse-jdt#181
@iloveeclipse
Removed ancient build scripts related to batch compiler (eclipse-jdt#181
5a20ddd 
)

Cleaning up org.eclipse.jdt.core and trying to sort out old unused
scripts from still used but requiring an update after move.

See eclipse-jdt#181
@iloveeclipse
Removed obsoleted "batch" and "compiler" build references (eclipse-jd…
5304e76 
…t#181)

See eclipse-jdt#181
@iloveeclipse
Removed obsoleted main-class attribute from jdt.core manifest (eclips…
ee8b5f2 
…e-jdt#181)

jdt.core can't be used anymore as self containing Java compiler library,
it is now org.eclipse.jdt.core.compiler.batch.

See eclipse-jdt#181
@iloveeclipse iloveeclipse changed the title Moved grammar and parser generation scripts to batch compiler (#181) Post-batch-compiler move cleanup (#181) Dec 2, 2022
@iloveeclipse
Copy link
Member Author

Replaced by #578

datho7561 added a commit to datho7561/eclipse.jdt.core that referenced this pull request Jul 9, 2024
@datho7561
[WIP] do not use recovered bindings when performing code select
2239f1d 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/eclipse.jdt.core that referenced this pull request Jul 10, 2024
@datho7561 @mickaelistria
[WIP] do not use recovered bindings when performing code select
8af6bf4 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
mickaelistria pushed a commit to mickaelistria/eclipse.jdt.core that referenced this pull request Jul 15, 2024
@datho7561 @mickaelistria
[WIP] do not use recovered bindings when performing code select
5336707 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
akurtakov pushed a commit to akurtakov/eclipse.jdt.core that referenced this pull request Jul 17, 2024
@datho7561 @mickaelistria
[WIP] do not use recovered bindings when performing code select
3d517b4 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
robstryker pushed a commit to robstryker/eclipse.jdt.core that referenced this pull request Jul 18, 2024
@datho7561 @mickaelistria
[WIP] do not use recovered bindings when performing code select
dd02866 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
robstryker pushed a commit to robstryker/eclipse.jdt.core that referenced this pull request Jul 18, 2024
@datho7561 @mickaelistria
[WIP] do not use recovered bindings when performing code select
cec8d81 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
robstryker pushed a commit to robstryker/eclipse.jdt.core that referenced this pull request Jul 18, 2024
@datho7561 @mickaelistria
[WIP] do not use recovered bindings when performing code select
afce2fc 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
robstryker pushed a commit to robstryker/eclipse.jdt.core that referenced this pull request Jul 18, 2024
@datho7561 @robstryker
[WIP] do not use recovered bindings when performing code select
1f84ef8 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
mickaelistria pushed a commit to mickaelistria/eclipse.jdt.core that referenced this pull request Jul 20, 2024
@datho7561 @akurtakov
[WIP] do not use recovered bindings when performing code select
741d24a 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
robstryker pushed a commit to robstryker/eclipse.jdt.core that referenced this pull request Jul 22, 2024
@datho7561 @akurtakov
[WIP] do not use recovered bindings when performing code select
3d66487 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
robstryker pushed a commit to robstryker/eclipse.jdt.core that referenced this pull request Jul 22, 2024
@datho7561 @robstryker
[WIP] do not use recovered bindings when performing code select
aad5f18 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
mickaelistria pushed a commit to mickaelistria/eclipse.jdt.core that referenced this pull request Jul 26, 2024
@datho7561 @mickaelistria
[WIP] do not use recovered bindings when performing code select
e240dab 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
akurtakov pushed a commit to akurtakov/eclipse.jdt.core that referenced this pull request Jul 29, 2024
@datho7561 @akurtakov
[WIP] do not use recovered bindings when performing code select
b83e9d2 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
akurtakov pushed a commit to akurtakov/eclipse.jdt.core that referenced this pull request Aug 16, 2024
@datho7561 @akurtakov
[WIP] do not use recovered bindings when performing code select
fe2cc67 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
mickaelistria pushed a commit to mickaelistria/eclipse.jdt.core that referenced this pull request Sep 5, 2024
@datho7561 @mickaelistria
[WIP] do not use recovered bindings when performing code select
50eaa2e 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
gayanper pushed a commit to gayanper/eclipse.jdt.core that referenced this pull request Sep 7, 2024
@datho7561 @gayanper
[WIP] do not use recovered bindings when performing code select
2f25a4b 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
mickaelistria pushed a commit to mickaelistria/eclipse.jdt.core that referenced this pull request Sep 9, 2024
@datho7561 @mickaelistria
[WIP] do not use recovered bindings when performing code select
aa95340 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
mickaelistria pushed a commit to mickaelistria/eclipse.jdt.core that referenced this pull request Sep 10, 2024
@datho7561 @mickaelistria
[WIP] do not use recovered bindings when performing code select
c729a8e 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
akurtakov pushed a commit to akurtakov/eclipse.jdt.core that referenced this pull request Sep 18, 2024
@datho7561 @mickaelistria
[WIP] do not use recovered bindings when performing code select
21c1137 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
mickaelistria pushed a commit to mickaelistria/eclipse.jdt.core that referenced this pull request Sep 24, 2024
@datho7561 @mickaelistria
[WIP] do not use recovered bindings when performing code select
61d1c47 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
mickaelistria pushed a commit to mickaelistria/eclipse.jdt.core that referenced this pull request Sep 24, 2024
@datho7561 @mickaelistria
[WIP] do not use recovered bindings when performing code select
200df6a 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
mickaelistria pushed a commit to mickaelistria/eclipse.jdt.core that referenced this pull request Oct 15, 2024
@datho7561 @mickaelistria
[WIP] do not use recovered bindings when performing code select
e6b16ec 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561 added a commit to datho7561/eclipse.jdt.core that referenced this pull request Oct 18, 2024
@datho7561 @rgrunber
[WIP] do not use recovered bindings when performing code select
edad4cb 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
mickaelistria pushed a commit to mickaelistria/eclipse.jdt.core that referenced this pull request Oct 23, 2024
@datho7561 @mickaelistria
[WIP] do not use recovered bindings when performing code select
3c32fe9 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
akurtakov pushed a commit to akurtakov/eclipse.jdt.core that referenced this pull request Nov 12, 2024
@datho7561 @mickaelistria
[WIP] do not use recovered bindings when performing code select
fa6dd1c 
- I think this is overkill, the recovered binding is often correct.
  However, I think this will fix the issue with duplicate type names
  being imported using `*`;

Fixes eclipse-jdt#577

Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iloveeclipse