Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename packages of copied code and file API requests against Platform #32

Closed
dmegert opened this issue Jul 7, 2016 · 1 comment
Closed

Rename packages of copied code and file API requests against Platform #32

dmegert opened this issue Jul 7, 2016 · 1 comment

Comments

@dmegert
Copy link

dmegert commented Jul 7, 2016

Some code got copied from other plug-ins and the original package names were used. This needs to be changed.

org.eclipse.jdt.internal.corext.javadoc
org.eclipse.jdt.internal.corext.util
org.eclipse.jdt.ui
org.eclipse.jface.internal.text.html

API requests need to be filed against the Platform to get rid of the copies.
dmegert pushed a commit that referenced this issue Jul 11, 2016
Renamed packages of copied code (issue #32)
5ff64b9
@dmegert
Copy link
Author

dmegert commented Jul 11, 2016

Rename has been done with 5ff64b9

@gorkem gorkem closed this as completed Aug 2, 2016
fbricon pushed a commit to fbricon/eclipse.jdt.ls that referenced this issue Aug 21, 2017
@ansyral
add handler to resolve class path (eclipse-jdtls#32)
5b21c99 
* add handler to resolve class path

Signed-off-by: xuzho <xuzho@microsoft.com>

* remove unused import

Signed-off-by: xuzho <xuzho@microsoft.com>

* resolve comments

Signed-off-by: xuzho <xuzho@microsoft.com>

* update error messages and remove suppresswarning attribute

Signed-off-by: xuzho <xuzho@microsoft.com>

* update error message

Signed-off-by: xuzho <xuzho@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gorkem @dmegert