Support change signature refactoring #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CsCherrYY
force-pushed
the
cs-changeSignature
branch
from
d23c0ec
to
263ff3c
Compare
CsCherrYY
requested review from
fbricon,
rgrunber,
snjeza,
testforstephen,
jdneo and
Eskibear
|
test this please |
CsCherrYY
force-pushed
the
cs-changeSignature
branch
from
2722bee
to
0463b75
Compare
jdneo
reviewed
Mar 15, 2023
...clipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/ChangeSignatureHandler.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/TextEditConverter.java
Outdated
Show resolved
Hide resolved
|
test this please |
jdneo
reviewed
Mar 15, 2023
| newExceptionInfos.add(ExceptionInfo.createInfoForAddedException(type)); | ||
| } | ||
| } else { | ||
| IType type = cu.getJavaProject().findType(exception.type); |
There was a problem hiding this comment.
Can we do some context-aware search first here? For example:
- Check if the exception type appears in the import declarations.
- If it's
Exception, just simply treat it asjava.lang.Exception
Signed-off-by: Shi Chen <chenshi@microsoft.com>
Signed-off-by: Shi Chen <chenshi@microsoft.com>
Signed-off-by: Shi Chen <chenshi@microsoft.com>
Signed-off-by: Shi Chen <chenshi@microsoft.com>
2. find possible match types in existing import declarations 3. filter non-public types for Exception Signed-off-by: Shi Chen <chenshi@microsoft.com>
CsCherrYY
force-pushed
the
cs-changeSignature
branch
from
eda6e38
to
dffe5f4
Compare
jdneo
reviewed
Mar 16, 2023
...clipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/ChangeSignatureHandler.java
Show resolved
Hide resolved
|
Would it make sense to add this behind a new extended client capability? In clients other than vscode this now shows a |
|
@mfussenegger Yes it makes sense. Would you like to raise a PR for that? |
mfussenegger
added a commit
to mfussenegger/nvim-jdtls
that referenced
this pull request
Mar 17, 2023
mfussenegger
added a commit
to mfussenegger/nvim-jdtls
that referenced
this pull request
Mar 17, 2023
mfussenegger
added a commit
to mfussenegger/nvim-jdtls
that referenced
this pull request
Mar 17, 2023
|
eclipse-jdt/eclipse.jdt.ui#428 was merged, so feel free to create a PR with TP update, and with some reference changes we can claw back ~6500 (I think) of copied code 🚀 |
|
kudos! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to redhat-developer/vscode-java#2967, more details and demo videos can be found in that PR.
This PR includes several added files which can be excluded after eclipse-jdt/eclipse.jdt.ui#428 got merged. To be specific, the classes in
org.eclipse.jdt.internalpackage.test cases can be found in
ChangeSignatureHandlerTest