Support change signature refactoring #2967

CsCherrYY · 2023-02-27T08:35:21Z

fix #2104

related to eclipse-jdtls/eclipse.jdt.ls#2497

a simple demo:

change.mp4

Signed-off-by: Shi Chen <chenshi@microsoft.com>

package.json

src/webview/changeSignature/App.tsx

src/webview/vscodeapiWrapper.ts

Signed-off-by: Shi Chen <chenshi@microsoft.com>

2. split refactor/preview buttons Signed-off-by: Shi Chen <chenshi@microsoft.com>

Signed-off-by: Shi Chen <chenshi@microsoft.com>

src/refactoring/changeSignaturePanel.ts

src/webview/utils.ts

2. align left margins Signed-off-by: Shi Chen <chenshi@microsoft.com>

2. set text as preview cursor Signed-off-by: Shi Chen <chenshi@microsoft.com>

jdneo · 2023-03-02T02:14:27Z

One more change request: Please add the description about this refactoring into https://github.com/redhat-developer/vscode-java/blob/master/document/_java.learnMoreAboutRefactorings.md.

And maybe other missing refactorings(e.g. extract interface)

You may encounter a problem that the document will not appear, a workaround for testing can be found at #2974

Signed-off-by: Shi Chen <chenshi@microsoft.com>

CsCherrYY · 2023-03-02T03:29:49Z

description added in d419eab

And maybe other missing refactorings(e.g. extract interface)

Let me create another PR to add the missing refactoring descriptions.

2. layout improvement 3. tips for re-open the refactoring 4. remain unchecked in the preview Signed-off-by: Shi Chen <chenshi@microsoft.com>

jdneo · 2023-03-10T07:56:08Z

Some feedback:

If set the access modifier to package-private, the signature preview will show package-private. Should be without any keyword.
Change the name of the parameter. After clicking reset, the name didn't reset to the original one.
Click the column header will highlight it, is this by design?
I'm a little bit confused by the Default value, could be helpful if some tooltip can be provided.

2. fix package private modifier 3. move backend functions from /webview/utils.ts to /webviewUtils.ts Signed-off-by: Shi Chen <chenshi@microsoft.com>

jdneo · 2023-03-14T01:53:45Z

I cannot change the added parameter name now

Signed-off-by: Shi Chen <chenshi@microsoft.com>

CsCherrYY · 2023-03-14T02:49:25Z

I cannot change the added parameter name now

My bad, just using same style for editing and non-editing parameter cell. 1cc199b fixes this.

jdneo · 2023-03-14T08:52:25Z

Click Keep original method as delegate to changed method, then click Reset. Nothing happens.

Looks like something wrong with the status handling.

2. use loadsh.cloneDeep() to keep state clean Signed-off-by: Shi Chen <chenshi@microsoft.com>

src/webview/changeSignature/App.tsx

Signed-off-by: Shi Chen <chenshi@microsoft.com>

jdneo

Looks good to me. We can experiment it in the insider before the next month's stable release.

xieu90 · 2023-04-04T08:30:27Z

how can i try this feature? in vscode Ctrl shift P install extension: java pack?

fbricon · 2023-04-04T08:36:14Z

You can install the latest vscode-java pre-release

xieu90 · 2023-04-04T09:20:01Z

i dont really see vscode-java pre-release in extension search window

i tried to change the java pack to pre-release and dont see change signature refactoring either.

fbricon · 2023-04-04T09:26:51Z

"Language Support for Java(TM) by Red Hat" is the full name for vscode-java:

xieu90 · 2023-04-04T09:44:01Z

it works now, i can see it, thank you ^^

CsCherrYY mentioned this pull request Feb 27, 2023

Support change signature refactoring eclipse-jdtls/eclipse.jdt.ls#2497

Merged

CsCherrYY force-pushed the cs-changeSignature branch from 81e3c08 to a340e9a Compare February 27, 2023 08:46

Support change signature refactoring

af35f2e

Signed-off-by: Shi Chen <chenshi@microsoft.com>

CsCherrYY force-pushed the cs-changeSignature branch from 71ab292 to af35f2e Compare February 28, 2023 01:43

use onInput() insteadof onChange()

80b80ad

Signed-off-by: Shi Chen <chenshi@microsoft.com>

Eskibear reviewed Feb 28, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

Eskibear reviewed Feb 28, 2023

View reviewed changes

src/webview/changeSignature/App.tsx Show resolved Hide resolved

Eskibear reviewed Feb 28, 2023

View reviewed changes

src/webview/vscodeapiWrapper.ts Outdated Show resolved Hide resolved

Eskibear reviewed Feb 28, 2023

View reviewed changes

src/webview/vscodeapiWrapper.ts Outdated Show resolved Hide resolved

Eskibear reviewed Feb 28, 2023

View reviewed changes

src/webview/vscodeapiWrapper.ts Outdated Show resolved Hide resolved

CsCherrYY added 3 commits February 28, 2023 15:50

address comments

48037a8

Signed-off-by: Shi Chen <chenshi@microsoft.com>

1. improve parameter/exception table

f8a6982

2. split refactor/preview buttons Signed-off-by: Shi Chen <chenshi@microsoft.com>

refine margin and enable debugging

5957344

Signed-off-by: Shi Chen <chenshi@microsoft.com>

jdneo reviewed Mar 1, 2023

View reviewed changes

src/refactoring/changeSignaturePanel.ts Outdated Show resolved Hide resolved

src/webview/utils.ts Outdated Show resolved Hide resolved

CsCherrYY added 2 commits March 1, 2023 16:10

1. address comments

4705403

2. align left margins Signed-off-by: Shi Chen <chenshi@microsoft.com>

1. add panel icon

4e83f55

2. set text as preview cursor Signed-off-by: Shi Chen <chenshi@microsoft.com>

add refactoring description

d419eab

Signed-off-by: Shi Chen <chenshi@microsoft.com>

1. add reset button

4de426f

2. layout improvement 3. tips for re-open the refactoring 4. remain unchecked in the preview Signed-off-by: Shi Chen <chenshi@microsoft.com>

1. address comments

0722f74

2. fix package private modifier 3. move backend functions from /webview/utils.ts to /webviewUtils.ts Signed-off-by: Shi Chen <chenshi@microsoft.com>

fix: parameters are not editable

1cc199b

Signed-off-by: Shi Chen <chenshi@microsoft.com>

1. address comments

2818564

2. use loadsh.cloneDeep() to keep state clean Signed-off-by: Shi Chen <chenshi@microsoft.com>

jdneo reviewed Mar 15, 2023

View reviewed changes

src/webview/changeSignature/App.tsx Outdated Show resolved Hide resolved

src/webview/changeSignature/App.tsx Outdated Show resolved Hide resolved

address comments

35acd8e

Signed-off-by: Shi Chen <chenshi@microsoft.com>

jdneo approved these changes Mar 16, 2023

View reviewed changes

jdneo merged commit 56b2516 into redhat-developer:master Mar 17, 2023
2 checks passed

jdneo added this to the Early April 2023 milestone Mar 20, 2023

This was referenced Mar 20, 2023

Add separate tsconfig for webview #3009

Merged

Fix extension loading #3005 #3006

Closed

Refactor method signature #1905

Closed

CsCherrYY deleted the cs-changeSignature branch April 5, 2023 01:05

rgrunber removed this from the Early April 2023 milestone Apr 12, 2023

gbroques mentioned this pull request Apr 14, 2023

Support change signature refactoring mfussenegger/nvim-jdtls#464

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support change signature refactoring #2967

Support change signature refactoring #2967

CsCherrYY commented Feb 27, 2023 •

edited

jdneo commented Mar 2, 2023

CsCherrYY commented Mar 2, 2023

jdneo commented Mar 10, 2023

jdneo commented Mar 14, 2023

CsCherrYY commented Mar 14, 2023

jdneo commented Mar 14, 2023

jdneo left a comment

xieu90 commented Apr 4, 2023

fbricon commented Apr 4, 2023

xieu90 commented Apr 4, 2023

fbricon commented Apr 4, 2023

xieu90 commented Apr 4, 2023

Support change signature refactoring #2967

Support change signature refactoring #2967

Conversation

CsCherrYY commented Feb 27, 2023 • edited

jdneo commented Mar 2, 2023

CsCherrYY commented Mar 2, 2023

jdneo commented Mar 10, 2023

jdneo commented Mar 14, 2023

CsCherrYY commented Mar 14, 2023

jdneo commented Mar 14, 2023

jdneo left a comment

Choose a reason for hiding this comment

xieu90 commented Apr 4, 2023

fbricon commented Apr 4, 2023

xieu90 commented Apr 4, 2023

fbricon commented Apr 4, 2023

xieu90 commented Apr 4, 2023

CsCherrYY commented Feb 27, 2023 •

edited