Support update Java project options. #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jdneo
commented
May 22, 2024
jdneo
commented
- All the options from JavaCore are supported via the delegate command 'java.project.updateSettings'.
- All the options from JavaCore are supported via the delegate command 'java.project.updateSettings'. Signed-off-by: Sheng Chen <sheche@microsoft.com>
rgrunber
reviewed
May 23, 2024
There was a problem hiding this comment.
When I was looking at your previous change to do the update for the m2e profile settings, I remember thinking that by placing the logic here, we also open the door later to do exactly this 😜 , so this makes sense.
Just a single comment I'd like confirmed regarding the side effects of setOptions(..)
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/commands/ProjectCommand.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sheng Chen <sheche@microsoft.com>
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/commands/ProjectCommand.java
Show resolved
Hide resolved
testforstephen
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.