-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RemoveBuildAnnotationsEnricher removal #1263
Comments
Should I remove the RemoveBuildAnnotationsEnricher class? |
RemoveBuildAnnotationsEnricher seems to be removing This annotations:
maven.jkube.io/source-url: jar:file:/home/rokumar/work/repos/jkube/gradle-plugin/it/src/it/dependency-resources/dependency/build/libs/dependency-0.0.1-SNAPSHOT.jar!/META-INF/jkube/kubernetes.yml Looks like this annotation is just used for some log statements which are printed during mergeResource phase: https://github.com/eclipse/jkube/blob/479858aa6719ffaabe8320c87ec43d129c78ffe6/jkube-kit/enricher/api/src/main/java/org/eclipse/jkube/kit/enricher/api/util/KubernetesResourceUtil.java#L830 Maybe we can remove these log statements and usage of |
I think RemoveBuildAnnotationsEnricher's annotation removal logic also needs some improvement. It is currently removing |
…-jkube#1263) RemoveBuildAnnotationsEnricher seems to be removing `maven.jkube.io/source-url` annotation which gets added in DependencyEnricher. This annotation doesn't seem to be getting used anywhere else. Delete RemoveBuildAnnotationsEnricher & Move `maven.jkube.io/source-url` annotation removal logic inside it to DependencyEnricher Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…-jkube#1263) RemoveBuildAnnotationsEnricher seems to be removing `maven.jkube.io/source-url` annotation which gets added in DependencyEnricher. This annotation doesn't seem to be getting used anywhere else. Delete RemoveBuildAnnotationsEnricher & Move `maven.jkube.io/source-url` annotation removal logic inside it to DependencyEnricher Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…-jkube#1263) RemoveBuildAnnotationsEnricher seems to be removing `maven.jkube.io/source-url` annotation which gets added in DependencyEnricher. This annotation doesn't seem to be getting used anywhere else. Delete RemoveBuildAnnotationsEnricher & `maven.jkube.io/source-url` annotation logic inside it to DependencyEnricher Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…-jkube#1263) RemoveBuildAnnotationsEnricher seems to be removing `maven.jkube.io/source-url` annotation which gets added in DependencyEnricher. This annotation doesn't seem to be getting used anywhere else. Delete RemoveBuildAnnotationsEnricher & `maven.jkube.io/source-url` annotation logic inside it to DependencyEnricher Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…-jkube#1263) RemoveBuildAnnotationsEnricher seems to be removing `maven.jkube.io/source-url` annotation which gets added in DependencyEnricher. This annotation doesn't seem to be getting used anywhere else. Delete RemoveBuildAnnotationsEnricher & `maven.jkube.io/source-url` annotation logic inside it to DependencyEnricher Signed-off-by: Rohan Kumar <rohaan@redhat.com>
RemoveBuildAnnotationsEnricher seems to be removing `maven.jkube.io/source-url` annotation which gets added in DependencyEnricher. This annotation doesn't seem to be getting used anywhere else. Delete RemoveBuildAnnotationsEnricher & `maven.jkube.io/source-url` annotation logic inside it to DependencyEnricher Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Description
The RemoveBuildAnnotationsEnricher seems to be completely outdated.
We should analyze what its initial purpose was. If it has nothing to do with Eclipse JKube, remove it.
AC
enricher-default
service definitionsRemove from docsThe text was updated successfully, but these errors were encountered: