Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

~~Rethink~~ Remove log messages like "Running in Kubernetes mode" that don't seem to be useful #1279

Closed
sunix opened this issue Feb 11, 2022 · 3 comments · Fixed by #1523
Closed

~~Rethink~~ Remove log messages like "Running in Kubernetes mode" that don't seem to be useful #1279

sunix opened this issue Feb 11, 2022 · 3 comments · Fixed by #1523
Assignees
@rohanKanojia
Labels
UX
Milestone
1.9.0

Comments

@sunix
Copy link
Member

sunix commented Feb 11, 2022 •
edited
Loading

Description

Seeing messages like "Running in Kubernetes mode" or ""Running in Openshift mode" are confusing me as an end user.
As a user, I don't know what are the consequences of these modes. I know this is a heritage from the past. These messages are more raising questions/doubts than providing useful informations about what JKube is doing.

I propose to remove these ones.

Info

  • Eclipse JKube version : 1.6.0
  • Maven version (mvn -v) :

  • Kubernetes / Red Hat OpenShift setup and version :

  • If it's a bug, how to reproduce :

  • If it's a feature request, what is your use case :

  • Sample Reproducer Project : [GitHub Clone URL]
@manusa
Copy link
Member

manusa commented Feb 11, 2022

Agreed. I can't remember if we are already loggin what kind of build we are doing.
e.g.

  • Local Docker
  • Local Jib
  • OpenShift Docker
  • OpenShift S2I
  • ...

@rohanKanojia
Copy link
Member

We used to have fabric8.mode in Fabric8 Maven Plugin which used to work both on Kubernetes and OpenShift. Now that we've specific plugins. I think it's safe to remove this message.

@manusa manusa added the UX label Feb 21, 2022
@manusa
Copy link
Member

manusa commented Feb 21, 2022

After internal discussion, the agreement is to remove this message from the plugins (+ test verifications)

@manusa manusa changed the title Rethink log messages like "Running in Kubernetes mode" that don't seem to be useful ~Rethink~ Remove log messages like "Running in Kubernetes mode" that don't seem to be useful Feb 21, 2022
@manusa manusa changed the title ~Rethink~ Remove log messages like "Running in Kubernetes mode" that don't seem to be useful ~~Rethink~~ Remove log messages like "Running in Kubernetes mode" that don't seem to be useful Mar 2, 2022
@rohanKanojia rohanKanojia self-assigned this May 25, 2022
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 25, 2022
@rohanKanojia
chore : Remove redundant log messages for plugin modes (eclipse-jkube…
86b28ac 
…#1279)

Remove log messages `Running in Kubernetes mode` which is redundant now
that we've separate plugins for Kubernetes and OpenShift.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 26, 2022
@rohanKanojia
chore : Remove redundant log messages for plugin modes (eclipse-jkube…
4396bc8 
…#1279)

Remove log messages `Running in Kubernetes mode` which is redundant now
that we've separate plugins for Kubernetes and OpenShift.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia mentioned this issue May 26, 2022
Merged
12 tasks
@manusa manusa added this to the 1.9.0 milestone Jun 1, 2022
manusa pushed a commit that referenced this issue Jun 8, 2022
@rohanKanojia @manusa
chore : Remove redundant log messages for plugin modes (#1279)
81d5772 
Remove log messages `Running in Kubernetes mode` which is redundant now
that we've separate plugins for Kubernetes and OpenShift.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@sunix sunix mentioned this issue Sep 26, 2022
Open
@ShivangMishra ShivangMishra mentioned this issue Apr 2, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
UX
Projects
None yet
Milestone
1.9.0
Development

Successfully merging a pull request may close this issue.

ui : Remove redundant log messages for plugin modes (#1279) rohanKanojia/jkube
3 participants
@manusa @sunix @rohanKanojia