Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VolumePermissionEnricher : Replace iteration with bulk Collection.addAll call #1362

Closed
rohanKanojia opened this issue Mar 18, 2022 · 5 comments · Fixed by #1391
Closed

VolumePermissionEnricher : Replace iteration with bulk Collection.addAll call #1362

rohanKanojia opened this issue Mar 18, 2022 · 5 comments · Fixed by #1391
Assignees
@Prathamkrishna
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers

Comments

@rohanKanojia
Copy link
Member

rohanKanojia commented Mar 18, 2022 •
edited
Loading

Description

We seem to be having this code in VolumePermissionEnricher:

https://github.com/eclipse/jkube/blob/d5653eeaedfcda146065e1b674040114ff3be1b0/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/VolumePermissionEnricher.java#L127-L130

Instead of looping over the collection, we can easily replace this with one-liner by using Collection.addAll call.
@rohanKanojia rohanKanojia added good first issue Good for newcomers first-timers-only Is this your first time contributing? This could be a good place to start! labels Mar 18, 2022
@Simba-97
Copy link
Contributor

@rohanKanojia can I work on this issue?

@Prathamkrishna
Copy link
Contributor

Hey @rohanKanojia I'd like to pick this up

@rohanKanojia
Copy link
Member Author

@Simba-97 : Sorry, I had created this for @Prathamkrishna . He asked me to do it on Gitter channel https://gitter.im/eclipse/jkube

@Simba-97
Copy link
Contributor

No problem @rohanKanojia 😄

@Prathamkrishna Prathamkrishna mentioned this issue Mar 18, 2022
Closed
12 tasks
@Prathamkrishna
Copy link
Contributor

Created the PR, @rohanKanojia lemme know if there's anything else:)

@manusa manusa linked a pull request Mar 23, 2022 that will close this issue
VolumePermissionEnricher : Replace iteration with bulk Collection.add… #1363
Closed
12 tasks
@Prathamkrishna Prathamkrishna mentioned this issue Mar 24, 2022
Merged
12 tasks
@manusa manusa linked a pull request Mar 25, 2022 that will close this issue
VolumePermissionEnricher : Replace iteration with bulk Collection.addAll call #1391
Merged
12 tasks
manusa pushed a commit that referenced this issue Mar 25, 2022
@Prathamkrishna @manusa
VolumePermissionEnricher : Replace iteration with bulk Collection.add…
73fcec3 
…All call #1362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Prathamkrishna Prathamkrishna

Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
3 participants
@rohanKanojia @Prathamkrishna @Simba-97