Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route Generation should support 8443 as default web port #1459

Closed
simonwg opened this issue Apr 19, 2022 · 0 comments · Fixed by #1914
Closed

Route Generation should support 8443 as default web port #1459

simonwg opened this issue Apr 19, 2022 · 0 comments · Fixed by #1914
Assignees
@rohanKanojia
Labels
enhancement New feature or request
Milestone
1.11.0

Comments

@simonwg
Copy link

simonwg commented Apr 19, 2022

Description

https://www.eclipse.org/jkube/docs/openshift-maven-plugin#resource-route-generation mentioned that 80, 443, 8080, 9080, 9090, 9443 are recognized by service and automatically be exposed. I think the port "8443" should be included as one of the recognized web ports

Info

  • Eclipse JKube version : 1.7.0

  • Kubernetes / Red Hat OpenShift setup and version : OpenShift 3.11

  • If it's a feature request, what is your use case : If the running service port 8443, manual "oc expose service my-service" will create the route with mapping port 8443 as well.
@manusa manusa added the enhancement New feature or request label Apr 26, 2022
@manusa manusa added this to the 1.8.0 milestone Apr 26, 2022
@manusa manusa modified the milestones: 1.8.0, 1.9.0 May 24, 2022
@manusa manusa modified the milestones: 1.9.0, 1.x Aug 4, 2022
@rohanKanojia rohanKanojia self-assigned this Nov 16, 2022
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Nov 16, 2022
@rohanKanojia
fix (jkube-kit/enricher) : Add 8443 as default web port to be conside…
0e5b2f4 
…red in Route Generation (eclipse-jkube#1459)

Add 8443 port to list of default web ports.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia mentioned this issue Nov 16, 2022
Merged
17 tasks
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Nov 24, 2022
@rohanKanojia
fix (jkube-kit/enricher) : Add 8443 as default web port to be conside…
e42475b 
…red in Route Generation (eclipse-jkube#1459)

Add 8443 port to list of default web ports.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Nov 25, 2022
@rohanKanojia
fix (jkube-kit/enricher) : Add 8443 as default web port to be conside…
2d0502d 
…red in Route Generation (eclipse-jkube#1459)

Add 8443 port to list of default web ports.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Dec 8, 2022
@rohanKanojia
fix (jkube-kit/enricher) : Add 8443 as default web port to be conside…
a17d4fe 
…red in Route Generation (eclipse-jkube#1459)

Add 8443 port to list of default web ports.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa manusa modified the milestones: 1.x, 1.11.0 Dec 14, 2022
manusa pushed a commit that referenced this issue Dec 14, 2022
@rohanKanojia @manusa
fix (jkube-kit/enricher) : Add 8443 as default web port to be conside…
db61040 
…red in Route Generation (#1459)

Add 8443 port to list of default web ports.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.11.0
3 participants
@manusa @simonwg @rohanKanojia