-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (jkube-kit/enricher) : Add 8443 as default web port to be considered in Route Generation (#1459) #1914
Conversation
Eclipse JKube CI ReportStarted new GH workflow run for #1914 (2022-12-08T07:51:38Z) ⚙️ JKube E2E Tests (3646191882)
|
Codecov Report
@@ Coverage Diff @@
## master #1914 +/- ##
============================================
+ Coverage 53.87% 53.90% +0.02%
- Complexity 4034 4037 +3
============================================
Files 480 480
Lines 21082 21082
Branches 2821 2821
============================================
+ Hits 11358 11364 +6
+ Misses 8558 8555 -3
+ Partials 1166 1163 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
930774e
to
1627f18
Compare
CHANGELOG.md
Outdated
@@ -29,6 +29,7 @@ Usage: | |||
### 1.10.0 (2022-11-10) | |||
* Fix #443: Add health check enricher for SmallRye Health | |||
* Fix #508: Kubernetes Remote Development (inner-loop) | |||
* Fix #1459: Route Generation should support `8443` as default web port |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be moved to 1.11-SNAPSHOT list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the changelog position I think everything else is fine
1627f18
to
5540142
Compare
…red in Route Generation (eclipse-jkube#1459) Add 8443 port to list of default web ports. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
5540142
to
7c2542f
Compare
+ Add documentation for Route Generation to JKube Kit Signed-off-by: Rohan Kumar <rohaan@redhat.com>
7c2542f
to
074f2c1
Compare
Kudos, SonarCloud Quality Gate passed! |
Description
Fixes #1459
Type of change
test, version modification, documentation, etc.)
Checklist