Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should detect and warn the user if jkube.createExternalUrl=true and ingress/route controller not available #1478

Closed
sunix opened this issue Apr 26, 2022 · 5 comments · Fixed by #1984
Assignees
Labels
demoable Issues which can be demoed during the Sprint review meeting UX
Milestone

Comments

@sunix
Copy link
Member

sunix commented Apr 26, 2022

Description

Basically when the ingress controller is not installed. JKube should detect it if it is creating an ingress that won't work. Cherry in the cake would be to tell which commands to run (for minikube: minikube addons enable ingress)

Info

  • Eclipse JKube version : 1.7.0
@sunix sunix added the UX label Apr 26, 2022
@sunix sunix changed the title Should detect and warn the user if jkube.createExternalUrl=true and ingress/route not available Should detect and warn the user if jkube.createExternalUrl=true and ingress/route controller not available Apr 26, 2022
@manusa
Copy link
Member

manusa commented May 16, 2022

This should be applicable only to the apply mojo, and probably only for specific Kubernetes platforms (such as Minikube).
For example, in regular clusters you might not have access to the kube-system namespace.

@rohanKanojia rohanKanojia self-assigned this Dec 28, 2022
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Dec 28, 2022
…te controller not available (eclipse-jkube#1478)

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Dec 29, 2022
…troller not available (eclipse-jkube#1478)

+ Add IngressControllerDetectorService which will try to detect whether
  any Ingress Controller is present in the cluster before applying
  Ingress. At the moment, it supports detecting these Ingress
  Controllers:
  - Contour
  - Ingress Kong
  - Ingress Nginx

  This is based on Kind Ingress guide, we can also expand it if we want
  to.
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia
Copy link
Member

rohanKanojia commented Dec 29, 2022

I've created PR for detecting Ingress controllers on Kubernets clusters #1984 .

However, I don't know if it's possible to disable Route Controller on OpenShift. I think it comes preinstalled with the OpenShift cluster.

Shall we also print some hint for user if he's using Ingress on OpenShift cluster and suggest using routes instead? Ingress is only generated when underlying platform is Kubernetes but it's possible that user provides Ingress fragment.

rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Dec 30, 2022
…troller not available (eclipse-jkube#1478)

+ Add IngressControllerDetectorService which will try to detect whether
  any Ingress Controller is present in the cluster before applying
  Ingress. At the moment, it supports detecting these Ingress
  Controllers:
  - Contour
  - Ingress Kong
  - Ingress Nginx
  - OpenShift Ingress Controller

  This is based on Kind Ingress guide, we can also expand it if we want
  to.
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa
Copy link
Member

manusa commented Jan 4, 2023

OpenShift supports Ingresses too.
In fact we might want to create some logic to create ingresses instead of routes in case an Ingress fragment is provided. Or even some flag to switch to Ingress generation instead of Route (similar to jkube.build.switchToDeployment).

@rohanKanojia
Copy link
Member

In fact we might want to create some logic to create ingresses instead of routes in case an Ingress fragment is provided. Or even some flag to switch to Ingress generation instead of Route (similar to jkube.build.switchToDeployment).

Shall I create a new issue for this?

@manusa
Copy link
Member

manusa commented Jan 5, 2023

Yes, please. However, we still need to investigate if we can switch completely to ingresses and see if OpenShift creates the routes for us (IIRC this was the behavior I saw but not 100% sure).

rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jan 5, 2023
…troller not available (eclipse-jkube#1478)

+ Add IngressControllerDetectorService which will try to detect whether
  any Ingress Controller is present in the cluster before applying
  Ingress. At the moment, it supports detecting these Ingress
  Controllers:
  - Contour
  - Ingress Kong
  - Ingress Nginx
  - OpenShift Ingress Controller

  This is based on Kind Ingress guide, we can also expand it if we want
  to.
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jan 9, 2023
…troller not available (eclipse-jkube#1478)

+ Add IngressControllerDetectorService which will try to detect whether
  any Ingress Controller is present in the cluster before applying
  Ingress. At the moment, it supports detecting these Ingress
  Controllers:
  - Contour
  - Ingress Kong
  - Ingress Nginx
  - OpenShift Ingress Controller

  This is based on Kind Ingress guide, we can also expand it if we want
  to.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jan 12, 2023
…troller not available (eclipse-jkube#1478)

+ Add IngressControllerDetectorService which will try to detect whether
  any Ingress Controller is present in the cluster before applying
  Ingress. At the moment, it supports detecting these Ingress
  Controllers:
  - Contour
  - Ingress Kong
  - Ingress Nginx
  - OpenShift Ingress Controller

  This is based on Kind Ingress guide, we can also expand it if we want
  to.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jan 30, 2023
…troller not available (eclipse-jkube#1478)

+ Add IngressControllerDetectorService which will try to detect whether
  any Ingress Controller is present in the cluster before applying
  Ingress. At the moment, it supports detecting these Ingress
  Controllers:
  - Contour
  - Ingress Kong
  - Ingress Nginx
  - OpenShift Ingress Controller

  This is based on Kind Ingress guide, we can also expand it if we want
  to.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Feb 7, 2023
…troller not available (eclipse-jkube#1478)

+ Add IngressControllerDetectorService which will try to detect whether
  any Ingress Controller is present in the cluster before applying
  Ingress. At the moment, it supports detecting these Ingress
  Controllers:
  - Contour
  - Ingress Kong
  - Ingress Nginx
  - OpenShift Ingress Controller

  This is based on Kind Ingress guide, we can also expand it if we want
  to.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Feb 15, 2023
…troller not available (eclipse-jkube#1478)

+ Add IngressControllerDetectorService which will try to detect whether
  any Ingress Controller is present in the cluster before applying
  Ingress. At the moment, it supports detecting these Ingress
  Controllers:
  - Contour
  - Ingress Kong
  - Ingress Nginx
  - OpenShift Ingress Controller

  This is based on Kind Ingress guide, we can also expand it if we want
  to.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Feb 16, 2023
…troller not available (eclipse-jkube#1478)

+ Add IngressControllerDetectorService which will try to detect whether
  any Ingress Controller is present in the cluster before applying
  Ingress. At the moment, it supports detecting these Ingress
  Controllers:
  - Contour
  - Ingress Kong
  - Ingress Nginx
  - OpenShift Ingress Controller

  This is based on Kind Ingress guide, we can also expand it if we want
  to.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Feb 16, 2023
…troller not available (eclipse-jkube#1478)

+ Add IngressControllerDetectorService which will try to detect whether
  any Ingress Controller is present in the cluster before applying
  Ingress. At the moment, it supports detecting these Ingress
  Controllers:
  - Contour
  - Ingress Kong
  - Ingress Nginx
  - OpenShift Ingress Controller

  This is based on Kind Ingress guide, we can also expand it if we want
  to.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Feb 16, 2023
…troller not available (eclipse-jkube#1478)

+ Add IngressControllerDetectorService which will try to detect whether
  any Ingress Controller is present in the cluster before applying
  Ingress. At the moment, it supports detecting these Ingress
  Controllers:
  - Contour
  - Ingress Kong
  - Ingress Nginx
  - OpenShift Ingress Controller

  This is based on Kind Ingress guide, we can also expand it if we want
  to.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Feb 21, 2023
…troller not available (eclipse-jkube#1478)

+ Add IngressControllerDetectorService which will try to detect whether
  any Ingress Controller is present in the cluster before applying
  Ingress. At the moment, it supports detecting these Ingress
  Controllers:
  - Contour
  - Ingress Kong
  - Ingress Nginx
  - OpenShift Ingress Controller

  This is based on Kind Ingress guide, we can also expand it if we want
  to.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Mar 1, 2023
…troller not available (eclipse-jkube#1478)

+ Add IngressControllerDetectorService which will try to detect whether
  any Ingress Controller is present in the cluster before applying
  Ingress. At the moment, it supports detecting these Ingress
  Controllers:
  - Contour
  - Ingress Kong
  - Ingress Nginx
  - OpenShift Ingress Controller

  This is based on Kind Ingress guide, we can also expand it if we want
  to.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@sunix sunix added the demoable Issues which can be demoed during the Sprint review meeting label Mar 3, 2023
manusa pushed a commit to rohanKanojia/jkube that referenced this issue Mar 31, 2023
…troller not available (eclipse-jkube#1478)

+ Add IngressControllerDetectorService which will try to detect whether
  any Ingress Controller is present in the cluster before applying
  Ingress. At the moment, it supports detecting these Ingress
  Controllers:
  - Contour
  - Ingress Kong
  - Ingress Nginx
  - OpenShift Ingress Controller

  This is based on Kind Ingress guide, we can also expand it if we want
  to.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 12, 2023
…troller not available (eclipse-jkube#1478)

+ Add IngressControllerDetectorService which will try to detect whether
  any Ingress Controller is present in the cluster before applying
  Ingress. At the moment, it supports detecting these Ingress
  Controllers:
  - Contour
  - Ingress Kong
  - Ingress Nginx
  - OpenShift Ingress Controller

  This is based on Kind Ingress guide, we can also expand it if we want
  to.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa manusa added this to the 1.13.0 milestone May 5, 2023
manusa pushed a commit that referenced this issue May 5, 2023
…troller not available (#1478)

+ Add IngressControllerDetectorService which will try to detect whether
  any Ingress Controller is present in the cluster before applying
  Ingress. At the moment, it supports detecting these Ingress
  Controllers:
  - Contour
  - Ingress Kong
  - Ingress Nginx
  - OpenShift Ingress Controller

  This is based on Kind Ingress guide, we can also expand it if we want
  to.

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
demoable Issues which can be demoed during the Sprint review meeting UX
Projects
None yet
3 participants