-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow additional services (via fragments) besides the default #1668
Comments
What happens with a service fragment that has no name? |
Currently, resource fragments are based on this pattern of having We set default name if I think relying on name should suffice, If not I can also add a fallback check for LabelSelector |
…ault (eclipse-jkube#1668) Rather than considering any Service type for merging with opinionated Service; check Service name matches controller name. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…ault (eclipse-jkube#1668) Rather than considering any Service type for merging with opinionated Service; check Service name matches controller name. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…ault (eclipse-jkube#1668) Rather than considering any Service type for merging with opinionated Service; check Service name matches controller name. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…ault (eclipse-jkube#1668) Rather than considering any Service type for merging with opinionated Service; check Service name matches controller name. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…ault (eclipse-jkube#1668) Rather than considering any Service type for merging with opinionated Service; check Service name matches controller name. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…ault (#1668) Rather than considering any Service type for merging with opinionated Service; check Service name matches controller name. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Component
JKube Kit
Is your enhancement related to a problem? Please describe
Our current
DefaultServiceEnricher
will act in three alternate ways:The following code snippet is responsible for this:
https://github.com/eclipse/jkube/blob/d653e0b6629d4fb15fecd60503e510dca5739523/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/DefaultServiceEnricher.java#L129-L146
This doesn't allow the definition of multiple services in case additional deployments or controller types are defined with fragments.
Describe the solution you'd like
The DefaultServiceEnricher#hasServices method should be improved to check if any of the existing services has a matching selector.
This might be complex because at the moment the service selector is provided later on in the
ProjectLabelEnricher
.https://github.com/eclipse/jkube/blob/4dfae9e6fa816873547d49651e05070c28e2d00e/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/ProjectLabelEnricher.java#L86-L96
💡 ❓ A solution might be to check if the existing service has a selector, in which case we should avoid merging, and adding a default service.
💡 ❓ The merge is also checking for the service name. Maybe we should just rely on that.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: