Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring Boot Generator should utilize the layered jar if present and use it as Docker layers #1674

Closed
friedeas opened this issue Jul 26, 2022 · 5 comments · Fixed by #2309
Closed

Spring Boot Generator should utilize the layered jar if present and use it as Docker layers #1674

friedeas opened this issue Jul 26, 2022 · 5 comments · Fixed by #2309
Assignees
@rohanKanojia
Labels
enhancement New feature or request

Comments

@friedeas
Copy link

Component

No response

Is your enhancement related to a problem? Please describe

Using Spring Boots “fat jar” in the Dockerfile instead of the layers provided in the layered jar gives away the potential for an optimized image.

Describe the solution you'd like

If a layered Spring Boot jar is detected the layers returned from the command
java -Djarmode=layertools -jar target/sample-app.jar list
should be used as layers in the generated Dockerfile

Describe alternatives you've considered

No response

Additional context

No response
@friedeas friedeas added the enhancement New feature or request label Jul 26, 2022
@ayushdubey755
Copy link
Contributor

@friedeas can you please specify the file in which changes has to be made?

@manusa
Copy link
Member

manusa commented Aug 2, 2022

The context for this issue is here: https://gitter.im/eclipse/jkube?at=62dfd33c76cd751a2f86b25f

A refactor of the Spring Boot generator is needed prior to changing its behavior. We will be taking care of these tasks.

@friedeas
Copy link
Author

@manusa is there any chance that the Spring Boot generator will be refactored in the near future to address this issue?

@manusa
Copy link
Member

manusa commented Nov 11, 2022

@manusa is there any chance that the Spring Boot generator will be refactored in the near future to address this issue?

Yes, updated support for Spring Boot is a priority right now.

@manusa manusa self-assigned this Nov 11, 2022
@manusa
Copy link
Member

manusa commented Jul 14, 2023 •
edited

Duplicate/similar of/to #763

@manusa manusa marked this as a duplicate of #763 Jul 14, 2023
@rohanKanojia rohanKanojia mentioned this issue Jul 19, 2023
Merged
17 tasks
@manusa manusa mentioned this issue Jul 26, 2023
Merged
17 tasks
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 26, 2023
@rohanKanojia
feat (jkube-kit/spring-boot) : SpringBootGenerator utilizes layered j…
f456d8f 
…ar if present and use it as Docker layers (eclipse-jkube#1674)

+ Add LayeredJarGenerator for layered container assembly for spring boot
+ Add gradle integration test for spring boot layered image generation

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia mentioned this issue Jul 26, 2023
Merged
18 tasks
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 31, 2023
@rohanKanojia
feat (jkube-kit/spring-boot) : SpringBootGenerator utilizes layered j…
127da66 
…ar if present and use it as Docker layers (eclipse-jkube#1674)

+ Add LayeredJarGenerator for layered container assembly for spring boot
+ Add gradle integration test for spring boot layered image generation

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 31, 2023
@rohanKanojia
feat (jkube-kit/spring-boot) : SpringBootGenerator utilizes layered j…
03534bd 
…ar if present and use it as Docker layers (eclipse-jkube#1674)

+ Add LayeredJarGenerator for layered container assembly for spring boot
+ Add gradle integration test for spring boot layered image generation

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 31, 2023
@rohanKanojia
feat (jkube-kit/spring-boot) : SpringBootGenerator utilizes layered j…
1fe573d 
…ar if present and use it as Docker layers (eclipse-jkube#1674)

+ Add LayeredJarGenerator for layered container assembly for spring boot
+ Add gradle integration test for spring boot layered image generation

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa manusa removed their assignment Aug 7, 2023
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Aug 8, 2023
@rohanKanojia
feat (jkube-kit/spring-boot) : SpringBootGenerator utilizes layered j…
ebbfe13 
…ar if present and use it as Docker layers (eclipse-jkube#1674)

+ Add LayeredJarGenerator for layered container assembly for spring boot
+ Add gradle integration test for spring boot layered image generation

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Aug 22, 2023
@rohanKanojia
feat (jkube-kit/spring-boot) : SpringBootGenerator utilizes layered j…
11fee58 
…ar if present and use it as Docker layers (eclipse-jkube#1674)

+ Add LayeredJarGenerator for layered container assembly for spring boot
+ Add gradle integration test for spring boot layered image generation

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Aug 25, 2023
@rohanKanojia
feat (jkube-kit/spring-boot) : SpringBootGenerator utilizes layered j…
26df5d2 
…ar if present and use it as Docker layers (eclipse-jkube#1674)

+ Add LayeredJarGenerator for layered container assembly for spring boot
+ Add gradle integration test for spring boot layered image generation

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Aug 28, 2023
@rohanKanojia
feat (jkube-kit/spring-boot) : SpringBootGenerator utilizes layered j…
2f39139 
…ar if present and use it as Docker layers (eclipse-jkube#1674)

+ Add LayeredJarGenerator for layered container assembly for spring boot
+ Add gradle integration test for spring boot layered image generation

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Aug 28, 2023
@rohanKanojia
feat (jkube-kit/spring-boot) : SpringBootGenerator utilizes layered j…
d697825 
…ar if present and use it as Docker layers (eclipse-jkube#1674)

+ Add LayeredJarGenerator for layered container assembly for spring boot
+ Add gradle integration test for spring boot layered image generation

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Aug 30, 2023
@rohanKanojia
feat (jkube-kit/spring-boot) : SpringBootGenerator utilizes layered j…
00d4f56 
…ar if present and use it as Docker layers (eclipse-jkube#1674)

+ Add LayeredJarGenerator for layered container assembly for spring boot
+ Add gradle integration test for spring boot layered image generation

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa pushed a commit that referenced this issue Aug 30, 2023
@rohanKanojia @manusa
feat (jkube-kit/spring-boot) : SpringBootGenerator utilizes layered j…
1636d4b 
…ar if present and use it as Docker layers (#1674)

+ Add LayeredJarGenerator for layered container assembly for spring boot
+ Add gradle integration test for spring boot layered image generation

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@friedeas friedeas mentioned this issue Sep 14, 2023
Closed
@manusa manusa mentioned this issue Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
4 participants
@manusa @rohanKanojia @ayushdubey755 @friedeas