Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s:watch with jkube.watch.mode=copy doesn't work #1704

Closed
rohanKanojia opened this issue Aug 17, 2022 · 0 comments · Fixed by #1705
Closed

k8s:watch with jkube.watch.mode=copy doesn't work #1704

rohanKanojia opened this issue Aug 17, 2022 · 0 comments · Fixed by #1705
Assignees
Labels
bug Something isn't working
Milestone

Comments

@rohanKanojia
Copy link
Member

Describe the bug

k8s:watch goal when run in Docker mode has various modes, see Watcher Docker Image documentation.

One of them is copy mode where changed files are directly copied to the root directory of the running container. It's pretty handy with web applications where applications could be redeployed by just copying updated war files.

This doesn't seem to be working at the moment.

Eclipse JKube version

SNAPSHOT

Component

Kubernetes Maven Plugin

Apache Maven version

No response

Gradle version

No response

Steps to reproduce

  1. In a tomcat/jetty based project, run mvn k8s:build k8s:resource k8s:apply k8s:watch -Djkube.watch.mode=copy
  2. In another terminal make some changes to project and run mvn package
  3. Instead of files getting copied into container, you'd see error message in k8s:watch logs. Application changes are also not reflected in deployed pod.

Expected behavior

mvn k8s:watch -Djkube.watch.mode=copy should copy changed files into container when mvn package is run

Runtime

Kubernetes (vanilla)

Kubernetes API Server version

1.23.7

Environment

Linux

Eclipse JKube Logs

No response

Sample Reproducer Project

No response

Additional context

No response

@rohanKanojia rohanKanojia added the bug Something isn't working label Aug 17, 2022
@rohanKanojia rohanKanojia self-assigned this Aug 17, 2022
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Aug 17, 2022
…ipse-jkube#1704)

Use Fabric8 Kubernetes Client Pod upload API to upload changed files
instead of manually copying via exec

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Aug 23, 2022
…ipse-jkube#1704)

Use Fabric8 Kubernetes Client Pod upload API to upload changed files
instead of manually copying via exec

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Nov 2, 2022
…ipse-jkube#1704)

Use Fabric8 Kubernetes Client Pod upload API to upload changed files
instead of manually copying via exec

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Nov 7, 2022
…ipse-jkube#1704)

Use Fabric8 Kubernetes Client Pod upload API to upload changed files
instead of manually copying via exec

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Nov 7, 2022
…ipse-jkube#1704)

Use Fabric8 Kubernetes Client Pod upload API to upload changed files
instead of manually copying via exec

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa manusa added this to the 1.10.0 milestone Nov 7, 2022
manusa pushed a commit that referenced this issue Nov 7, 2022
Use Fabric8 Kubernetes Client Pod upload API to upload changed files
instead of manually copying via exec

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants