Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hacktoberfest] AssemblyFiles.entries may be 'final' #1782

Closed
1 task done
manusa opened this issue Oct 5, 2022 · 3 comments · Fixed by #1803
Closed
1 task done

[Hacktoberfest] AssemblyFiles.entries may be 'final' #1782

manusa opened this issue Oct 5, 2022 · 3 comments · Fixed by #1803
Assignees
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers Hacktoberfest Issues accountable for the Hacktoberfest
Milestone

Comments

@manusa
Copy link
Member

manusa commented Oct 5, 2022

Description

The following statement is reported as a code style issue:

https://github.com/eclipse/jkube/blob/892ba7092627a7f0712ff68427361fb2d9cd976d/jkube-kit/build/api/src/main/java/org/eclipse/jkube/kit/build/api/assembly/AssemblyFiles.java#L32

  • should be changed to:
    private final List<AssemblyFileEntry> entries = new ArrayList<>();

Before you start

Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

How to manually test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console.
(Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

@manusa manusa added good first issue Good for newcomers first-timers-only Is this your first time contributing? This could be a good place to start! Hacktoberfest Issues accountable for the Hacktoberfest labels Oct 5, 2022
@ishu-thakur
Copy link
Contributor

Hi @manusa can you assign that to me :) ?

ishu-thakur added a commit to ishu-thakur/jkube that referenced this issue Oct 5, 2022
…kube#1782

Signed-off-by: Ishu Thakur <ishuthakur251299@gmail.com>
@manusa
Copy link
Member Author

manusa commented Oct 6, 2022

Hi @ishu-thakur
You've already contributed to the project, issues labeled with first-timers-only are limited to first time contributors to the project (and at most one).
The whole point of these very simple issues is for people to get acquainted with the project, with the Eclipse Foundation processes, and in general with free open source software. Consider that it takes longer for me to create the issue than to create the actual fix. We believe that these kind of issues help the community and this is why we put an extra-effort submitting them, if a single contributor was to tackle all of these issues, our effort would be wasted.

@manish-singh-bisht
Copy link
Contributor

Hey @manusa can I do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers Hacktoberfest Issues accountable for the Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants