Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuring nodeSelector spec for controller via xml/groovy DSL configuration #2335

Closed
rohanKanojia opened this issue Aug 22, 2023 Discussed in #2334 · 2 comments · Fixed by #2859
Closed
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@rohanKanojia
Copy link
Member

rohanKanojia commented Aug 22, 2023

Discussed in #2334

Originally posted by maodia August 21, 2023
Hi, i get a small problem that i am going to deploy my image to some particular k8s node (use nodeSelector spec in the deployment yaml) but i do not know how to configure it in my xml configuration file. I searched it in the docs and found nothing about this.

  • ControllerResourceConfig
@manusa manusa added the enhancement New feature or request label Jan 10, 2024
@Adityaturkhade
Copy link

I would like to pick this issue but I need some help and elaboration

@rohanKanojia
Copy link
Member Author

@Adityaturkhade You would need to add a new field Map<String, String> nodeSelectors in ControllerResourceConfig.

This field would be read in PodTemplateHandler that would set .withNodeSelector() builder method in createPodSpec with value set in this field.

A similar field schedule was added to ControllerResourceConfig in this pull request #2012

Apart from making these changes, you would need to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants