-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jkube-kit): Initial Support for CronJob (#1954) #2012
Conversation
Eclipse JKube CI ReportStarted new GH workflow run for #2012 (2023-03-31T04:25:34Z) ⚙️ JKube E2E Tests (4571437965)
|
688667c
to
4daaa9d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2012 +/- ##
============================================
+ Coverage 55.85% 55.89% +0.04%
- Complexity 4308 4316 +8
============================================
Files 482 483 +1
Lines 21269 21303 +34
Branches 2847 2847
============================================
+ Hits 11879 11907 +28
- Misses 8175 8181 +6
Partials 1215 1215
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
...cher/generic/src/main/java/org/eclipse/jkube/enricher/generic/DefaultControllerEnricher.java
Show resolved
Hide resolved
jkube-kit/enricher/api/src/main/java/org/eclipse/jkube/kit/enricher/handler/CronJobHandler.java
Show resolved
Hide resolved
...it/enricher/api/src/main/java/org/eclipse/jkube/kit/enricher/handler/PodTemplateHandler.java
Outdated
Show resolved
Hide resolved
...it/enricher/api/src/test/java/org/eclipse/jkube/kit/enricher/handler/CronJobHandlerTest.java
Outdated
Show resolved
Hide resolved
4daaa9d
to
8caec53
Compare
8caec53
to
3b2d6f6
Compare
jkube-kit/doc/src/main/asciidoc/inc/enricher/controller/_jkube_controller.adoc
Show resolved
Hide resolved
jkube-kit/doc/src/main/asciidoc/inc/resource-generation/_controller_resource_generation.adoc
Show resolved
Hide resolved
3b2d6f6
to
5496b13
Compare
5496b13
to
ee53002
Compare
We would also need to add an integration test for CronJob like the rest of the controllers here: This can be done in a follow-up PR. |
@rohanKanojia I'll open a new PR for integration tests when this one gets merged. |
ee53002
to
e3d94ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
Just needs rebasing and we should be able to merge it.
Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>
Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>
e3d94ff
to
8f9e04e
Compare
SonarCloud Quality Gate failed. |
Description
Fixes #1954
Type of change
test, version modification, documentation, etc.)
Checklist