-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(controller-enricher): Add support for configuring nodeSelector spec for controller via xml/groovy DSL configuration #2859
Conversation
…y DSL configs Signed-off-by: Sun Seng David TAN <sutan@redhat.com>
…r via Maven XML and Groovy DSL Signed-off-by: Sun Seng David TAN <sutan@redhat.com>
Eclipse JKube CI ReportStarted new GH workflow run for #2859 (2024-03-28T10:47:15Z) ⚙️ JKube E2E Tests (8465951737)
|
documentation on the way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2859 +/- ##
=============================================
+ Coverage 59.36% 70.60% +11.24%
- Complexity 4586 5015 +429
=============================================
Files 500 486 -14
Lines 21211 19468 -1743
Branches 2830 2507 -323
=============================================
+ Hits 12591 13746 +1155
+ Misses 7370 4495 -2875
+ Partials 1250 1227 -23 ☔ View full report in Codecov by Sentry. |
Description
Fixes #2335
Type of change
test, version modification, documentation, etc.)
Checklist