Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jkube-healthcheck-karaf startup feature name is wrong #622

Closed
mcarlett opened this issue Mar 25, 2021 · 3 comments · Fixed by #684
Closed

jkube-healthcheck-karaf startup feature name is wrong #622

mcarlett opened this issue Mar 25, 2021 · 3 comments · Fixed by #684
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@mcarlett
Copy link
Contributor

hi, in the documentation about jkube-healthcheck-karaf specific enricher is defined the karaf startup feature named jkube.karaf-checks. It should be jkube-karaf-checks
@rohanKanojia
Copy link
Member

@mcarlett : Thanks a lot for reporting this. Would you like to submit a PR to fix this?

@rohanKanojia rohanKanojia added documentation Improvements or additions to documentation good first issue Good for newcomers labels Mar 25, 2021
@ohbus
Copy link
Contributor

ohbus commented Apr 23, 2021 •
edited
Loading

@rohanKanojia where can I find the source of this doc?

@ohbus
Copy link
Contributor

ohbus commented Apr 23, 2021

@rohanKanojia where can I find the source of this doc?

Found it here kubernetes-maven-plugin/doc/src/main/asciidoc/inc/enricher/_jkube_healthcheck_karaf.adoc

ohbus added a commit to ohbus/jkube that referenced this issue Apr 23, 2021
@ohbus
resolve eclipse-jkube#622
8e1fc83 
Signed-off-by: Subhrodip Mohanta <subhrodipmohanta@gmail.com>
@ohbus ohbus mentioned this issue Apr 23, 2021
Merged
12 tasks
ohbus added a commit to ohbus/jkube that referenced this issue Apr 23, 2021
@ohbus
updated changelog for eclipse-jkube#622
c1068c8 
Signed-off-by: Subhrodip Mohanta <subhrodipmohanta@gmail.com>
ohbus added a commit to ohbus/jkube that referenced this issue Apr 23, 2021
@ohbus
resolve eclipse-jkube#622
ebec85d 
Signed-off-by: Subhrodip Mohanta <subhrodipmohanta@gmail.com>
ohbus added a commit to ohbus/jkube that referenced this issue Apr 23, 2021
@ohbus
updated changelog for eclipse-jkube#622
c65ff2c 
Signed-off-by: Subhrodip Mohanta <subhrodipmohanta@gmail.com>
manusa pushed a commit that referenced this issue Apr 27, 2021
@ohbus @manusa
resolve #622
52d3146 
Signed-off-by: Subhrodip Mohanta <subhrodipmohanta@gmail.com>
manusa pushed a commit that referenced this issue Apr 27, 2021
@ohbus @manusa
updated changelog for #622
4bdd0d5 
Signed-off-by: Subhrodip Mohanta <subhrodipmohanta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Corrected jkube-healthcheck-karaf in doc ohbus/jkube
3 participants
@ohbus @rohanKanojia @mcarlett