Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace occurences of keySet() with entrySet() when value are needed #634

Closed
theexplorist opened this issue Mar 27, 2021 · 1 comment · Fixed by #646
Closed

Replace occurences of keySet() with entrySet() when value are needed #634

theexplorist opened this issue Mar 27, 2021 · 1 comment · Fixed by #646
Assignees
@theexplorist
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@theexplorist
Copy link
Contributor

theexplorist commented Mar 27, 2021 •
edited by rohanKanojia
Loading

Description

There are few places in our codebase where keySet() is used instead of entrySet(), which leads to a sonar code smell.

"entrySet()" should be iterated when both the key and value are needed.

We need to replace these occureneces of keySet() with entrySet() to make it SonarCloud compliant![0]

[0] https://sonarcloud.io/organizations/jkubeio/rules?open=java%3AS2864&rule_key=java%3AS2864
@theexplorist
Copy link
Contributor Author

Please assign me this issue @rohanKanojia

@rohanKanojia rohanKanojia added help wanted Extra attention is needed good first issue Good for newcomers labels Mar 27, 2021
@theexplorist theexplorist mentioned this issue Apr 1, 2021
Merged
12 tasks
manusa pushed a commit that referenced this issue Apr 13, 2021
@theexplorist @manusa
Fix #634 : Replace occurences of keySet() with entrySet() when value …
27e6baf 
…are needed

Signed-off-by: theexplorist <kartiksapra005@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theexplorist theexplorist

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace occurences of keySet() with entrySet() when value are needed
2 participants
@rohanKanojia @theexplorist