Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve our Liveness/Readiness Probe XML configuration support #672

Closed
rohanKanojia opened this issue Apr 20, 2021 · 0 comments · Fixed by #719
Closed

Improve our Liveness/Readiness Probe XML configuration support #672

rohanKanojia opened this issue Apr 20, 2021 · 0 comments · Fixed by #719
Assignees
@rohanKanojia
Labels
enhancement New feature or request
Projects
Sprint #202 Sprint #203
Milestone
1.4.0

Comments

@rohanKanojia
Copy link
Member

rohanKanojia commented Apr 20, 2021 •
edited
Loading

Right now our support for Liveness/Readiness probes is okay but I think it's not up to date with latest releases of kubernetes.

I see some things missing:
@manusa manusa added the enhancement New feature or request label May 7, 2021
@manusa manusa added this to the 1.4.0 milestone May 7, 2021
@manusa manusa added this to Backlog in Sprint #202 May 24, 2021
@manusa manusa moved this from Backlog to Planned in Sprint #202 May 26, 2021
@rohanKanojia rohanKanojia self-assigned this Jun 11, 2021
@manusa manusa moved this from Planned to In progress in Sprint #202 Jun 11, 2021
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 11, 2021
@rohanKanojia
Fix eclipse-jkube#672: Add missing fields in ProbeConfig for configur…
d956e7f 
…ing Readiness/Liveness Probes

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
This was referenced Jun 11, 2021
Merged
Open
@manusa manusa moved this from In progress to Review in Sprint #202 Jun 14, 2021
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 15, 2021
@rohanKanojia
Fix eclipse-jkube#672: Add missing fields in ProbeConfig for configur…
b837c45 
…ing Readiness/Liveness Probes

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa manusa added this to Review in Sprint #203 Jun 16, 2021
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 18, 2021
@rohanKanojia
Fix eclipse-jkube#672: Add missing fields in ProbeConfig for configur…
0e22d41 
…ing Readiness/Liveness Probes

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 22, 2021
@rohanKanojia
Fix eclipse-jkube#672: Add missing fields in ProbeConfig for configur…
f52acff 
…ing Readiness/Liveness Probes

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 22, 2021
@rohanKanojia
Fix eclipse-jkube#672: Add missing fields in ProbeConfig for configur…
311ae7f 
…ing Readiness/Liveness Probes

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 23, 2021
@rohanKanojia
Fix eclipse-jkube#672: Add missing fields in ProbeConfig for configur…
02474bf 
…ing Readiness/Liveness Probes

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jul 2, 2021
@rohanKanojia
Fix eclipse-jkube#672: Add missing fields in ProbeConfig for configur…
e1bd82b 
…ing Readiness/Liveness Probes

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sprint #203 automation moved this from Review to Done Jul 5, 2021
manusa pushed a commit that referenced this issue Jul 5, 2021
@rohanKanojia @manusa
Fix #672: Add missing fields in ProbeConfig for configuring Readiness…
acd5106 
…/Liveness Probes

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
enhancement New feature or request
Projects
No open projects
Sprint #202
  
Review
Sprint #203
  
Done
Milestone
1.4.0
2 participants
@manusa @rohanKanojia