Fix #672: Add missing fields in ProbeConfig for configuring Readiness/Liveness Probes

[rohanKanojia]

Description

Fix #672

• Add missing fields in ProbeConfig for configuring liveness/readiness
• Added a check to keep host null in case it matches localhost

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change
• Chore (non-breaking change which doesn't affect codebase;
  test, version modification, documentation, etc.)

Checklist

• I have read the contributing guidelines
• I signed-off my commit with a user that has signed the Eclipse Contributor Agreement
• I Added CHANGELOG entry
• I have implemented unit tests to cover my changes
• I have updated the documentation accordingly
• No new bugs, code smells, etc. in SonarCloud report
• I tested my code in Kubernetes
• I tested my code in OpenShift

[manusa]

Eclipse JKube CI Report

Started new GH workflow run for #719 (2021-07-05T07:57:12Z)

⚙️ JKube E2E Tests (994242733)

• ✔️ Bootstrap CI test run (#719)
• ✔️ K8S v1.12.0 dockerfile (#719)
• ✔️ K8S v1.12.0 other (#719)
• ✔️ K8S v1.12.0 quarkus (#719)
• ✔️ K8S v1.12.0 quarkus-native (#719)
• ✔️ K8S v1.12.0 springboot (#719)
• ✔️ K8S v1.12.0 webapp (#719)
• ✔️ K8S v1.20.1 dockerfile (#719)
• ✔️ K8S v1.20.1 other (#719)
• ✔️ K8S v1.20.1 quarkus (#719)
• ✔️ K8S v1.20.1 quarkus-native (#719)
• ✔️ K8S v1.20.1 springboot (#719)
• ✔️ K8S v1.20.1 webapp (#719)
• ✔️ OpenShift v3.11.0 other (#719)
• ✔️ OpenShift v3.11.0 quarkus (#719)
• ✔️ OpenShift v3.11.0 springboot (#719)
• ✔️ OpenShift v3.11.0 webapp (#719)
• ✔️ OpenShift v3.9.0 other (#719)
• ✔️ OpenShift v3.9.0 quarkus (#719)
• ✔️ OpenShift v3.9.0 springboot (#719)
• ✔️ OpenShift v3.9.0 webapp (#719)
• ✔️ Windows (#719)

[codecov]

Codecov Report

Merging #719 (e1bd82b) into master (2a2c30a) will increase coverage by 0.00%.
The diff coverage is 85.00%.

@@            Coverage Diff            @@
##             master     #719   +/-   ##
=========================================
  Coverage     46.20%   46.21%           
- Complexity     3241     3246    +5     
=========================================
  Files           413      413           
  Lines         19849    19856    +7     
  Branches       2781     2781           
=========================================
+ Hits           9172     9176    +4     
- Misses         9659     9661    +2     
- Partials       1018     1019    +1     

Impacted Files	Coverage Δ
...eclipse/jkube/kit/config/resource/ProbeConfig.java	0.00% <0.00%> (ø)
...clipse/jkube/kit/common/util/KubernetesHelper.java	30.71% <83.33%> (+0.71%)	⬆️
...lipse/jkube/kit/enricher/handler/ProbeHandler.java	98.24% <100.00%> (-0.04%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a2c30a...e1bd82b. Read the comment docs.

[manusa]

Please rebase, please fix the code smell

[rohanKanojia]

I'm not using IntSupplier for a reason here. It doesn't handle nullable integers well

[manusa]

I'm not using IntSupplier for a reason here. It doesn't handle nullable integers well

Then remove the warning and provide a hint as to why we use Supplier instead:

    @SuppressWarnings("java:S4276") // IntSupplier throws NullPointerException when unboxing null Integers
    private void setTimeoutInProbeIfNotNull(Probe probe, Supplier<Integer> integerSupplier, BiConsumer<Integer, Probe> probeConsumer) {

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

89.3% Coverage
0.0% Duplication