Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress enricher merges opinionated defaults with provided Fragments #791

Open
4 tasks
manusa opened this issue Jul 26, 2021 · 1 comment
Open
4 tasks

Comments

@manusa
Copy link
Member

manusa commented Jul 26, 2021

Description

The Ingress enricher is only used for Ingress creation purposes.

Scenarios such as the following are not covered:

  • Fragment provided for extensions/v1beta1
    • 2.1 Generate and merge ingress with apiVersion networking.k8s.io/v1
    • 2.2 Generate and merge ingress with apiVersion extensions/v1beta1
  • Fragment provided for networking.k8s.io/v1
    • 3.1 Generate and merge ingress with apiVersion networking.k8s.io/v1 (-Djkube.enricher.jkube-ingress.targetApiVersion='networking.k8s.io/v1') ❌
    • 3.2 Generate and merge ingress with apiVersion extensions/v1beta1

This feature might be interesting for users who target different Kubernetes clusters and might want to generate different resources Ingress APIs but provide a single Fragment.

Currently the Ingress Enricher only generates the opinionated Ingress in case there's no Ingress fragment with a matching name. For this cases, it might be interesting to convert the Ingress to the desired target version in case is set.

Another pending question is if we want to merge opinionated defaults with missing information in the provided fragments.

Relates to

@manusa
Copy link
Member Author

manusa commented Jul 26, 2021

It might be worth considering the Deployment approach and provide specific enrichers to perform the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant