busybox image name is hardcoded in VolumePermissionEnricher class, need to make it as config

[kumar-cloud]

Description

busybox image name is hardcoded in VolumePermissionEnricher.java Line 115.
Now a days every one have their own ECR registries maintained.Few people are using Dockerhub pro version to pull images.
Due to this , we are getting rate limiting issue from Dockerhub. So Please make this image name as config for enricher.

Where is this code :

return new ContainerBuilder()
                        .withName(ENRICHER_NAME)
                        .withImage("busybox")
                        .withImagePullPolicy("IfNotPresent")
                        .withCommand(createChmodCommandArray(mountPoints))
                        .withVolumeMounts(createMounts(mountPoints))
                        .build();

Thanks to @rohanKanojia for providing hint on fix.
How to fix:
Maybe we can add another field in enricher configuration to override image name: https://github.com/eclipse/jkube/blob/master/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/VolumePermissionEnricher.java#L57

Info

• Eclipse JKube version : master
• Maven version (mvn -v) : Apache Maven 3.6.3

• Kubernetes / Red Hat OpenShift setup and version :

• If it's a bug, how to reproduce :

• Use Dockerhub as registry without credentials. recently Dockerhub has introduced RateLimiting for Pulling images.

[manusa]

Hi @kumar-cloud,

Thanks for reporting.

Maybe we can add another field in enricher configuration to override image name: https://github.com/eclipse/jkube/blob/master/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/VolumePermissionEnricher.java#L57

Yes, this is exactly what needs to be done. Would you be interested in contributing a fix?

[kumar-cloud]

Hi Team Yes I would like to if possible. But I never contributed anything till now. It would be a good experience for me. If someone help me with steps...On process.

…

On Wed, 8 Sep 2021, 13:02 Marc Nuri, ***@***.***> wrote: Hi @kumar-cloud <https://github.com/kumar-cloud>, Thanks for reporting. Maybe we can add another field in enricher configuration to override image name: https://github.com/eclipse/jkube/blob/master/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/VolumePermissionEnricher.java#L57 Yes, this is exactly what needs to be done. Would you be interested in contributing a fix? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#891 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AP4AR4NBISK7FYPOG537JPDUA3U7PANCNFSM5DTSJVOQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[rohanKanojia]

@kumar-cloud : We have this webpage regarding contributing to project[0]. Please review it and see if it helps(You're also welcome to provide feedback regarding improvements since you would have a fresh perspective).

In case of any doubt, you can always reach out to us on Gitter Channel[1] (like you previously did). Our channel is usually active during IST/CET timezones.

[0] https://www.eclipse.org/jkube/contributing
[1] https://gitter.im/eclipse/jkube

[kumar-cloud]

Hi Marc Can you please merge the fix.

…

On Wed, 8 Sep 2021, 19:01 Marc Nuri, ***@***.***> wrote: Assigned #891 <#891> to @kumar-cloud <https://github.com/kumar-cloud>. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#891 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AP4AR4KQWKBEISY3QEWKMCDUA47AZANCNFSM5DTSJVOQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.