Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: JKubeTarArchive doesn't load files in memory #1036

Merged

Conversation

manusa
Copy link
Member

@manusa manusa commented Oct 19, 2021

Description

fix: JKubeTarArchive doesn't load files in memory

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #1036 (0cddc7a) into feat/gradle-plugin (b3b81ca) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##             feat/gradle-plugin    #1036      +/-   ##
========================================================
- Coverage                 48.60%   48.59%   -0.02%     
  Complexity                 3607     3607              
========================================================
  Files                       453      453              
  Lines                     20793    20794       +1     
  Branches                   2839     2839              
========================================================
- Hits                      10107    10105       -2     
- Misses                     9606     9609       +3     
  Partials                   1080     1080              
Impacted Files Coverage Δ
...pse/jkube/kit/common/archive/JKubeTarArchiver.java 93.75% <100.00%> (+0.20%) ⬆️
...e/jkube/kit/config/service/PortForwardService.java 70.10% <0.00%> (-3.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3b81ca...0cddc7a. Read the comment docs.

@manusa manusa self-assigned this Oct 19, 2021
@manusa manusa merged commit e3d6e42 into eclipse-jkube:feat/gradle-plugin Oct 19, 2021
@manusa manusa added this to the 1.5.0 milestone Oct 19, 2021
@manusa manusa deleted the feat/gradle-plugin-memory branch October 19, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants