KubernetesWatchTask Prerequisite refactor in JKube Kit #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1127 +/- ##
============================================
+ Coverage 49.24% 49.26% +0.02%
- Complexity 3608 3615 +7
============================================
Files 456 455 -1
Lines 20588 20595 +7
Branches 2802 2809 +7
============================================
+ Hits 10138 10146 +8
+ Misses 9379 9373 -6
- Partials 1071 1076 +5
Continue to review full report at Codecov.
|
12 tasks
rohanKanojia
force-pushed
the
pr/prerequisite-1109
branch
from
fbe0d52
to
bbedf2b
Compare
manusa
reviewed
Nov 23, 2021
Comment on lines
89
to
90
| .groupId(SPRING_BOOT_GROUP_ID) | ||
| .artifactId(SPRING_BOOT_MAVEN_PLUGIN_ARTIFACT_ID) |
There was a problem hiding this comment.
Please, use a string here, if there's an error/typo in the constant it won't be revealed
manusa
reviewed
Nov 23, 2021
Comment on lines
108
to
109
| .groupId(SPRING_BOOT_GROUP_ID) | ||
| .artifactId(SPRING_BOOT_GRADLE_PLUGIN_ARTIFACT_ID) |
There was a problem hiding this comment.
rohanKanojia
force-pushed
the
pr/prerequisite-1109
branch
from
bbedf2b
to
36e22ae
Compare
manusa
reviewed
Nov 24, 2021
...s-maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/build/ApplyMojo.java
Show resolved
Hide resolved
manusa
reviewed
Nov 24, 2021
...maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/develop/WatchMojo.java
Show resolved
Hide resolved
manusa
reviewed
Nov 24, 2021
jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/JKubeProjectUtil.java
Show resolved
Hide resolved
manusa
reviewed
Nov 24, 2021
.../plugin/src/test/java/org/eclipse/jkube/maven/plugin/mojo/GeneratedPluginDescriptorTest.java
Outdated
Show resolved
Hide resolved
+ SpringBootWatcher.isApplicable returns true for Spring Boot Gradle Plugin + Remove JKubeArtifactResolverService; Add utility method in JKubeProjectUtil to resolve artifact from dependencies instead + SpringBootUtil.getSpringBootPluginConfiguration also fetches configuration of Spring Boot Gradle Plugin Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/prerequisite-1109
branch
from
36e22ae
to
35e9d4a
Compare
|
SonarCloud Quality Gate failed. |
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Nov 25, 2021
localRepositoryBaseDirectory only seemed to be only getting used by JKubeArtifactResolverService which was removed in eclipse-jkube#1127. Removing this field as it's no longer used anywhere. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Nov 25, 2021
localRepositoryBaseDirectory only seemed to be only getting used by JKubeArtifactResolverService which was removed in eclipse-jkube#1127. Removing this field as it's no longer used anywhere. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Nov 25, 2021
localRepositoryBaseDirectory only seemed to be only getting used by JKubeArtifactResolverService which was removed in eclipse-jkube#1127. Removing this field as it's no longer used anywhere. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Nov 25, 2021
localRepositoryBaseDirectory only seemed to be only getting used by JKubeArtifactResolverService which was removed in eclipse-jkube#1127. Removing this field as it's no longer used anywhere. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa
pushed a commit
that referenced
this pull request
Nov 26, 2021
localRepositoryBaseDirectory only seemed to be only getting used by JKubeArtifactResolverService which was removed in #1127. Removing this field as it's no longer used anywhere. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prerequisite Refactor in JKube Kit for #1109
configuration of Spring Boot Gradle Plugin
Signed-off-by: Rohan Kumar rohaan@redhat.com
Type of change
test, version modification, documentation, etc.)
Checklist