JavaProject: Remove unused localRepositoryBaseDirectory field

localRepositoryBaseDirectory only seemed to be only getting used by JKubeArtifactResolverService which was removed in eclipse-jkube#1127. Removing this field as it's no longer used anywhere. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia · Nov 25, 2021 · bf3f769 · bf3f769
1 parent 120cb44
commit bf3f769
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 15 deletions.
diff --git a/jkube-kit/common-maven/src/main/java/org/eclipse/jkube/kit/common/util/MavenUtil.java b/jkube-kit/common-maven/src/main/java/org/eclipse/jkube/kit/common/util/MavenUtil.java
@@ -316,15 +316,11 @@ public static JavaProject convertMavenProjectToJKubeProject(MavenProject mavenPr
         JavaProject.JavaProjectBuilder builder = JavaProject.builder();
 
         Properties properties = new Properties();
-        File localRepositoryBaseDir = null;
 
         if (mavenProject.getProperties() != null) {
             properties.putAll(mavenProject.getProperties());
         }
         if (mavenSession != null) {
-            if (mavenSession.getLocalRepository().getBasedir() != null) {
-                localRepositoryBaseDir = new File(mavenSession.getLocalRepository().getBasedir());
-            }
             if (mavenSession.getUserProperties() != null) {
                 properties.putAll(mavenSession.getUserProperties());
             }
@@ -348,7 +344,6 @@ public static JavaProject convertMavenProjectToJKubeProject(MavenProject mavenPr
                 .packaging(mavenProject.getPackaging())
                 .dependencies(getDependencies(mavenProject))
                 .dependenciesWithTransitive(getTransitiveDependencies(mavenProject))
-                .localRepositoryBaseDirectory(localRepositoryBaseDir)
                 .plugins(getPlugins(mavenProject));
 
         if (mavenProject.getOrganization() != null) {

diff --git a/jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/JavaProject.java b/jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/JavaProject.java
@@ -182,13 +182,6 @@ public class JavaProject implements Serializable {
    * @return The project's generated artifact file.
    */
   private File artifact;
-  /**
-   * Directory for the project's local repository.
-   *
-   * @param localRepositoryBaseDirectory New directory for the project's local repository.
-   * @return The project's local repository directory.
-   */
-  private File localRepositoryBaseDirectory;
   /**
    * Project's packaging type. Specifies the type of artifact the project produces.
    *
@@ -249,8 +242,8 @@ public JavaProject(
       Properties properties, @Singular List<String> compileClassPathElements, @Singular List<Dependency> dependencies,
       List<Dependency> dependenciesWithTransitive, @Singular List<Plugin> plugins,
       String site, String description, String organizationName, String documentationUrl,
-      String buildFinalName, File artifact, File localRepositoryBaseDirectory,
-      String packaging, String issueManagementSystem, String issueManagementUrl, String url, String scmUrl, String scmTag,
+      String buildFinalName, File artifact, String packaging, String issueManagementSystem, String issueManagementUrl,
+      String url, String scmUrl, String scmTag,
       @Singular List<Maintainer> maintainers) {
 
     this.name = name;
@@ -271,7 +264,6 @@ public JavaProject(
     this.documentationUrl = documentationUrl;
     this.buildFinalName = buildFinalName;
     this.artifact = artifact;
-    this.localRepositoryBaseDirectory = localRepositoryBaseDirectory;
     this.packaging = packaging;
     this.issueManagementSystem = issueManagementSystem;
     this.issueManagementUrl = issueManagementUrl;