feat (jkube-kit/quarkus): Add startup probe in QuarkusHealthCheckEnricher (#1468) #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #1524 (2022-06-09T15:47:50Z) ⚙️ JKube E2E Tests (2469448145)
|
Codecov Report
@@ Coverage Diff @@
## master #1524 +/- ##
============================================
+ Coverage 51.44% 51.46% +0.01%
- Complexity 3824 3828 +4
============================================
Files 459 459
Lines 20700 20707 +7
Branches 2816 2816
============================================
+ Hits 10649 10656 +7
Misses 8935 8935
Partials 1116 1116
Continue to review full report at Codecov.
|
rohanKanojia
approved these changes
May 30, 2022
|
Could you please update quarkus health check enricher documentation as well? |
|
Sure |
anurag-rajawat
force-pushed
the
quarkus-probe
branch
2 times, most recently
from
b34f2c6
to
38b3de1
Compare
|
Startup probe endpoint was only added to MicroProfile starting on 3.1. We need to check which versions (if not all) of Quarkus are based on a new version of MicroProfile to make sure that the enricher is only activated for these versions. |
rohanKanojia
force-pushed
the
quarkus-probe
branch
from
38b3de1
to
fb7b5e2
Compare
anurag-rajawat
commented
Jun 9, 2022
jkube-kit/jkube-kit-quarkus/src/test/java/org/eclipse/jkube/quarkus/QuarkusUtilsTest.java
Show resolved
Hide resolved
rohanKanojia
force-pushed
the
quarkus-probe
branch
from
fb7b5e2
to
f413280
Compare
…cher (eclipse-jkube#1468) Signed-off-by: Anurag Singh Rajawat <anuragsinghrajawat22@gmail.com>
…probes when Quarkus version >= 2.1 Looks like Quarkus only seems to support these new `/q/health/started` endpoints since `2.1.0.Final`. Add a check to only add startup probes in projects using Quarkus 2.1.x and later. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
quarkus-probe
branch
from
f413280
to
fe21e30
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Merged
12 tasks
sunix
approved these changes
Jun 10, 2022
rohanKanojia
approved these changes
Jun 20, 2022
manusa
reviewed
Jul 5, 2022
Comment on lines
+52
to
+53
| private static final int QUARKUS_MAJOR_VERSION_SINCE_STARTUP_CHANGE = 2; | ||
| private static final int QUARKUS_MINOR_VERSION_SINCE_STARTUP_CHANGE = 1; |
There was a problem hiding this comment.
Could you please provide information on why we're checking for Quarkus 2.1 instead of Quarkus 2.0
AFAIK Smallrye health was updated to 3.0 in this PR quarkusio/quarkus#16333 which was released along with Quarkus 2.0
There was a problem hiding this comment.
Just tried again on a simple Quarkus project with SmallRYE dependency. These were my observations:
- On 2.0.0.Final
/q/health/startedgives 404 - On 2.1.0.Final
q/health/startedgives 200 OK
There was a problem hiding this comment.
It seems that there was some work done on Quarkus in between the Smallrye dependency update and the startup probe wiring.
#1524 (comment) - @rohanKanojia:
|
manusa
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix: #1468
Type of change
test, version modification, documentation, etc.)
Checklist