2.x - MicroProfile 4 and Vert.x 4 #16333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Vert.x version to 4.0.3 Update Netty version to 4.1.60 Update gRPC version to 1.35.0 (protoc 3.14.0) Update vert.x mutiny to version 2.2.0 Update Hibernate Reactive to 1.0.0.CR1.Vertx4 Update SmallRye Reactive Messaging to 3.0.0 Update Quarkus HTTP to 4.0.0.Alpha4
* Use the proper Base64 encoder * Substitutions for undertow + JSON Undertow explicitly excludes Jackson Core so we need to make sure that Vert.x json doesn't trip the native image compilation
- the body handler is now required - avoid deprecated API - update tests to follow the ApolloWS protocol which is now enforced (https://github.com/apollographql/subscriptions-transport-ws/blob/master/PROTOCOL.md)
…FS and not when the uploaded file has been read.
* Increase netty maxOrder to 3 to make grpc runSize fit chunkSize * Change netty.allocator.maxOrder only if grpc is enabled
|
|
machi1990
reviewed
Apr 7, 2021
extensions/redis-client/runtime/src/main/java/io/quarkus/redis/client/runtime/RedisConfig.java
Show resolved
Hide resolved
gsmet
requested changes
Apr 7, 2021
famod
reviewed
Apr 7, 2021
| <properties> | ||
| <maven.compiler.parameters>true</maven.compiler.parameters> | ||
| <!-- needs to wait for smallrye-reactive-messaging-health to update MP health to 3.0 --> | ||
| <enforcer.skip>true</enforcer.skip> |
There was a problem hiding this comment.
Is this about dependencyConvergence? I'm a bit wary about skipping all enforcer rules like this, e.g. see #15841.
I understand that it's of utmost importance get this branch merged but this should be narrowed ASAP after the merge.
There was a problem hiding this comment.
I will fix it just after the merge.
MP Health has nasty breaking changes, so we had to work upstream first. I've all fine now.
Failing Jobs
Test Failures⚙️ JVM Tests - JDK 15 #📦 extensions/resteasy-reactive/quarkus-resteasy-reactive-jsonb/deployment# Tests: 16
+ Success: 14
- Failures: 1
- Errors: 0
! Skipped: 1❌
|
gsmet
approved these changes
Apr 8, 2021
|
What a milestone! AWESOME work @cescoffier! |
|
Great work! @cescoffier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.