doc : Move build related documentation from plugins to jkube-kit/doc (#1006)
#1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #1712 (2022-09-07T14:55:12Z) ⚙️ JKube E2E Tests (3008473824)
|
Merged
12 tasks
Codecov Report
@@ Coverage Diff @@
## master #1712 +/- ##
=========================================
Coverage 52.92% 52.92%
Complexity 3935 3935
=========================================
Files 464 464
Lines 20752 20752
Branches 2816 2816
=========================================
Hits 10983 10983
Misses 8646 8646
Partials 1123 1123 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rohanKanojia
force-pushed
the
pr/issue1006-3
branch
2 times, most recently
from
8190511
to
5c951fe
Compare
manusa
reviewed
Aug 29, 2022
| ---- | ||
| endif::[] | ||
|
|
||
| [[jkube-plugin]] |
There was a problem hiding this comment.
JKube plugins deserve a complete separate section, maybe similar to profiles or any other generic feature JKube offers.
We can then link each operation section to its relevant JKubePlugin parts
manusa
reviewed
Aug 29, 2022
| [[jkube-plugin]] | ||
| .JKube Plugins | ||
|
|
||
| This plugin supports so call *jkube-plugins* which are used during the build phase. |
There was a problem hiding this comment.
Suggested change
| This plugin supports so call *jkube-plugins* which are used during the build phase. | |
| This plugin supports so call *jkube-plugins* which have entry points that can be bound to the different JKube operation phases. |
🤷
rohanKanojia
force-pushed
the
pr/issue1006-3
branch
from
5c951fe
to
3dc371f
Compare
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/issue1006-3
branch
from
3dc371f
to
f1ae0a6
Compare
While moving build plugins related docs to gradle; It makes more sense to move all documentation for image build related configuration options from plugins to jkube kit in order to avoid duplication. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/issue1006-3
branch
from
f1ae0a6
to
51742b1
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
manusa
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
to move all documentation for image build related configuration options
from plugins to jkube kit in order to avoid duplication.
quickstarts/maven/pluginto gradleSigned-off-by: Rohan Kumar rohaan@redhat.com
Type of change
test, version modification, documentation, etc.)
Checklist