Fixing code style issue with declaration #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #1801 (2022-10-07T06:05:19Z) ⚙️ JKube E2E Tests (3202513636)
|
Codecov Report
@@ Coverage Diff @@
## master #1801 +/- ##
============================================
+ Coverage 52.95% 53.00% +0.05%
- Complexity 3937 3938 +1
============================================
Files 464 464
Lines 20745 20745
Branches 2809 2809
============================================
+ Hits 10985 10996 +11
+ Misses 8637 8623 -14
- Partials 1123 1126 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hi! @jivjen In order to contribute to Eclipse, you would need to create an Eclipse Account and Sign Eclipse Contributor Agreement. Once you've created an eclipse account you would need to update your commit message with a Signed-off-by: footer. You can do it like this: Amend your previous commit with signed off footer git commit --amend --signoff |
Signed-off-by: jivjen <jival.jisil@yahoo.co.in>
… fix-code-style Signed-off-by: jivjen <jival.jisil@yahoo.co.in>
… fix-code-style Signed-off-by: jivjen <jival.jisil@yahoo.co.in>
… fix-code-style Signed-off-by: jivjen <jival.jisil@yahoo.co.in>
… fix-code-style Signed-off-by: jivjen <jival.jisil@yahoo.co.in>
… fix-code-style
@anurag-rajawat I created an account with the same email id and signed the ECA but still the check is failing for some reason. Any idea what might the issue be? |
Signed-off-by: jivjen <jival.jisil@yahoo.co.in>
… fix-code-style Signed-off-by: jivjen <jival.jisil@yahoo.co.in>
|
Kudos, SonarCloud Quality Gate passed! |
Maybe because of not re-validating your PR after signing the ECA. |
ShubhraSuman
pushed a commit
to ShubhraSuman/jkube
that referenced
this pull request
Oct 10, 2022
* Fixing code style issue with declaration * Fixing code style issue with declaration Signed-off-by: jivjen <jival.jisil@yahoo.co.in> * retrigger checks * retrigger checks Signed-off-by: jivjen <jival.jisil@yahoo.co.in> Signed-off-by: jivjen <jival.jisil@yahoo.co.in> Signed-off-by: ShubhraSuman <shubhrasuman@Shubhras-MacBook-Air.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1799
Type of change
test, version modification, documentation, etc.)
Checklist