fix (jkube-kit/build) : ImageNameFormatter should respect + in image tag as per Semver specifications
#1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #1859 (2022-10-19T06:19:20Z) ⚙️ JKube E2E Tests (3279125462)
|
Signed-off-by: Christian Mäder <christian.maeder@nxt.engineering>
Codecov Report
@@ Coverage Diff @@
## master #1859 +/- ##
============================================
+ Coverage 53.00% 53.04% +0.04%
Complexity 3938 3938
============================================
Files 464 464
Lines 20744 20771 +27
Branches 2809 2816 +7
============================================
+ Hits 10996 11019 +23
- Misses 8622 8624 +2
- Partials 1126 1128 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
|
The license check had a technical error while executing (Connection Timeout). And I can't re-start it, unfortunately. |
|
@cimnine : On a quick look this looks like a valid fix to me. Not sure how we missed it. |
rohanKanojia
changed the title
+ in image tag as per Semver specifications
|
@cimnine : I'm sorry for the super delayed response. Do you still need this fix? |
|
I no longer work on a project where it's relevant to me, but I believe it's still relevant overall. |
This was referenced Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
n/aThis pull request deals with the fact that a Docker image tag is not allowed to contain a
+. When working with SemVer, a+is used to indicate the beginning of the build metadata section.When
project.versioncontains such build metadata, then currently the build fails:In this PR, I made two changes:
-SNAPSHOTis correctly detected as pre-release section, even if there is build metadata following it.+sign is replaced by-to bring the whole tag in line with Docker's naming conventions. This is configurable using the new propertyjkube.image.tag.semver_plus_substitution.Type of change
test, version modification, documentation, etc.)
Checklist