-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: create remote dev session id and reuse it #2087
Conversation
Eclipse JKube CI ReportStarted new GH workflow run for #2087 (2023-03-28T10:18:43Z) ⚙️ JKube E2E Tests (4541642095)
|
Codecov Report
@@ Coverage Diff @@
## master #2087 +/- ##
============================================
+ Coverage 55.78% 55.79% +0.01%
- Complexity 4295 4296 +1
============================================
Files 482 482
Lines 21238 21245 +7
Branches 2843 2843
============================================
+ Hits 11847 11854 +7
Misses 8179 8179
Partials 1212 1212
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -48,6 +50,7 @@ public Service toKubernetesService() { | |||
.withType(type) | |||
.addToSelector("app", REMOTE_DEVELOPMENT_APP) | |||
.addToSelector("group", REMOTE_DEVELOPMENT_GROUP) | |||
.addToSelector("jkube-id", sessionID.toString()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to rename it? I propose something like remote-dev-id
or remote-dev-session-id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to rename it? I propose something like
remote-dev-id
orremote-dev-session-id
👍
We should also have those strings defined as constants but that should be part of a separate PR
Fixes 2086 Signed-off-by: Jeff MAURY <jmaury@redhat.com>
Signed-off-by: Marc Nuri <marc@marcnuri.com>
Kudos, SonarCloud Quality Gate passed! |
Description
Fixes #2086
Type of change
test, version modification, documentation, etc.)
Checklist