Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resource validation works with new json-schema-validator version #417

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Sep 30, 2020

Description

Fix #415: Fixed resource validation for new json-schema-validator version

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #417 into master will increase coverage by 0.45%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #417      +/-   ##
============================================
+ Coverage     35.84%   36.29%   +0.45%     
- Complexity     2316     2344      +28     
============================================
  Files           379      379              
  Lines         18824    18839      +15     
  Branches       2755     2756       +1     
============================================
+ Hits           6747     6838      +91     
+ Misses        11264    11181      -83     
- Partials        813      820       +7     
Impacted Files Coverage Δ Complexity Δ
...e/kit/common/util/validator/ResourceValidator.java 80.61% <88.88%> (+80.61%) 21.00 <2.00> (+21.00)
.../util/validator/IgnoreResourceMemoryLimitRule.java 25.00% <0.00%> (+25.00%) 2.00% <0.00%> (+2.00%)
...ommon/util/validator/IgnorePortValidationRule.java 66.66% <0.00%> (+66.66%) 3.00% <0.00%> (+3.00%)
...ipse/jkube/kit/common/util/ResourceClassifier.java 87.50% <0.00%> (+87.50%) 2.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 082bc46...f573981. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

90.9% 90.9% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@manusa manusa merged commit ca5dbd2 into eclipse-jkube:master Sep 30, 2020
@manusa manusa deleted the fix/resource-validation branch September 30, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants