Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Helm linter no longer fails with generated charts #608

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

manusa
Copy link
Member

@manusa manusa commented Mar 8, 2021

Description

fix #591: Helm linter no longer fails with generated charts

  • updated jkube-kit-resource-helm to use assertj instead of hamcrest

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

+ updated jkube-kit-resource-helm to use assertj instead of hamcrest

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #608 (97f057e) into master (7e377f7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #608      +/-   ##
============================================
+ Coverage     42.46%   42.47%   +0.01%     
- Complexity     2885     2887       +2     
============================================
  Files           404      404              
  Lines         19490    19494       +4     
  Branches       2762     2762              
============================================
+ Hits           8277     8281       +4     
  Misses        10222    10222              
  Partials        991      991              
Impacted Files Coverage Δ Complexity Δ
...ava/org/eclipse/jkube/kit/resource/helm/Chart.java 96.87% <100.00%> (+0.32%) 21.00 <2.00> (+2.00)
...g/eclipse/jkube/kit/resource/helm/HelmService.java 93.27% <100.00%> (+0.05%) 26.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e377f7...97f057e. Read the comment docs.

@manusa
Copy link
Member Author

manusa commented Mar 8, 2021

Helm E2E tests are now failing since the Chart.yaml output now ourputs an extra apiVersion: v1 field.

I'll update the tests once this PR gets merged.

@manusa manusa requested a review from rohanKanojia March 8, 2021 16:36
@manusa manusa merged commit 8a03b82 into eclipse-jkube:master Mar 9, 2021
@manusa manusa deleted the fix/helm-linter branch March 9, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Linter fails with error: ' apiVersion is required'
2 participants