Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Custom Resource fragments can be replaced and recreated with FKC 5.3.x #689

Merged
merged 1 commit into from May 5, 2021

Conversation

manusa
Copy link
Member

@manusa manusa commented May 3, 2021

Description

fix: Custom Resource fragments can be replaced and recreated with FKC 5.3.x

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #689 (b59e35c) into master (8063d3d) will increase coverage by 0.10%.
The diff coverage is 59.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #689      +/-   ##
============================================
+ Coverage     44.32%   44.42%   +0.10%     
+ Complexity     3070     3069       -1     
============================================
  Files           410      410              
  Lines         19610    19570      -40     
  Branches       2770     2762       -8     
============================================
+ Hits           8692     8694       +2     
+ Misses         9910     9869      -41     
+ Partials       1008     1007       -1     
Impacted Files Coverage Δ Complexity Δ
...eclipse/jkube/kit/config/service/ApplyService.java 19.90% <42.85%> (-0.13%) 53.00 <0.00> (ø)
.../service/kubernetes/KubernetesUndeployService.java 92.72% <66.66%> (ø) 16.00 <1.00> (ø)
...onfig/service/kubernetes/KubernetesClientUtil.java 32.05% <84.61%> (+13.40%) 10.00 <5.00> (-1.00) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8063d3d...b59e35c. Read the comment docs.

… 5.3.x

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa manusa added this to Review in Sprint #200 May 3, 2021
@manusa manusa requested a review from rohanKanojia May 3, 2021 13:20
@manusa manusa added this to the 1.3.0 milestone May 3, 2021
@sonarcloud
Copy link

sonarcloud bot commented May 3, 2021

@manusa manusa added the bug Something isn't working label May 3, 2021
@manusa manusa merged commit c9b11d4 into eclipse-jkube:master May 5, 2021
Sprint #200 automation moved this from Review to Done May 5, 2021
@manusa manusa deleted the fix/cr-edit-in-kc-5.3 branch May 5, 2021 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Sprint #200
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants