-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Bump httpclient from 4.5.10 to 4.5.13 #726
Conversation
6b0675e
to
816d0f3
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## master #726 +/- ##
============================================
- Coverage 45.05% 45.03% -0.02%
Complexity 3135 3135
============================================
Files 413 413
Lines 19659 19659
Branches 2764 2764
============================================
- Hits 8857 8854 -3
- Misses 9790 9793 +3
Partials 1012 1012
Continue to review full report at Codecov.
|
Hi @rohanKanojia could you have a look? The last failing codecov check doesn't seem to be relevant to this fix. |
You're right. it seems to be complaining about coverage which I don't think we should worry about in a version bump PR |
@manusa @rohanKanojia Is there any reason why it's not accepted yet? Thank you. |
We need the Eclipse legal team to approve a CQ for the updated dependenc Everything looks good, so as soon as it gets approved we'll merge. Should be part of the next release. |
CQs required for this PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
Description
Fix #725. Thanks!
Type of change
test, version modification, documentation, etc.)
Checklist