Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Bump httpclient from 4.5.10 to 4.5.13 #726

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

tadayosi
Copy link
Contributor

@tadayosi tadayosi commented Jun 16, 2021

Description

Fix #725. Thanks!

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #726 (816d0f3) into master (f627c84) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #726      +/-   ##
============================================
- Coverage     45.05%   45.03%   -0.02%     
  Complexity     3135     3135              
============================================
  Files           413      413              
  Lines         19659    19659              
  Branches       2764     2764              
============================================
- Hits           8857     8854       -3     
- Misses         9790     9793       +3     
  Partials       1012     1012              
Impacted Files Coverage Δ
...e/jkube/kit/config/service/PortForwardService.java 71.57% <0.00%> (-3.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f627c84...816d0f3. Read the comment docs.

@tadayosi
Copy link
Contributor Author

Hi @rohanKanojia could you have a look? The last failing codecov check doesn't seem to be relevant to this fix.

@rohanKanojia
Copy link
Member

You're right. it seems to be complaining about coverage which I don't think we should worry about in a version bump PR

@rohanKanojia rohanKanojia requested a review from manusa June 16, 2021 05:16
@tadayosi
Copy link
Contributor Author

@manusa @rohanKanojia Is there any reason why it's not accepted yet? Thank you.

@manusa
Copy link
Member

manusa commented Jun 23, 2021

@manusa @rohanKanojia Is there any reason why it's not accepted yet? Thank you.

We need the Eclipse legal team to approve a CQ for the updated dependencyies.

Everything looks good, so as soon as it gets approved we'll merge. Should be part of the next release.

@rohanKanojia
Copy link
Member

rohanKanojia commented Jun 24, 2021

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 57018d3 into eclipse-jkube:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade HttpClient to 4.5.13 or later
3 participants