Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #877: LogMojo: Change access modifiers to protected for use in XML configuration #905

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Fix #877: LogMojo: Change access modifiers to protected for use in XML configuration #905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Usage:
* Fix #923: QuakusGenerator not applicable when using `io.quarkus.platform` groupId
* Fix #895: FileUtil#createDirectory works for files with trailing separator (`/`)
* Fix #913: Make provider name configurable
* Fix #877: LogMojo: Change access modifiers to protected for use in XML configuration

### 1.4.0 (2021-07-27)
* Fix #253: Refactor JKubeServiceHub's BuildService election mechanism via ServiceLoader
Expand Down
10 changes: 10 additions & 0 deletions kubernetes-maven-plugin/doc/src/main/asciidoc/inc/goals/develop/_jkube-log.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,16 @@ If your pod has multiple containers you can configure the container name to log
mvn {goal-prefix}:log -Djkube.log.container=foo
----

.Example XML configuration for log goal
[source,xml,indent=0,subs="verbatim,quotes,attributes"]
<plugin>
<configuration>
<logFollow>true</logFollow>
<logContainer>container</logContainer>
<logPod>pod</logPod>
</configuration>
</plugin>
manusa marked this conversation as resolved.
Show resolved Hide resolved

[[Supported-Properties-Log]]
=== Supported Properties for Log goal

Expand Down
6 changes: 3 additions & 3 deletions ...aven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/develop/LogMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@
public class LogMojo extends ApplyMojo {

@Parameter(property = "jkube.log.follow", defaultValue = "true")
private boolean logFollow;
protected boolean logFollow;
@Parameter(property = "jkube.log.container")
private String logContainerName;
protected String logContainerName;
@Parameter(property = "jkube.log.pod")
private String logPodName;
protected String logPodName;

@Override
protected void applyEntities(final KubernetesClient kubernetes, String fileName, final Collection<HasMetadata> entities) {
Expand Down