Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #877: LogMojo: Change access modifiers to protected for use in XML configuration #905

Conversation

yraydhitya
Copy link
Contributor

@yraydhitya yraydhitya commented Sep 11, 2021

Description

Fixes #877

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@yraydhitya yraydhitya changed the title Maven plugin log xml configuration Fix #877: LogMojo: Change access modifiers to protected for use in XML configuration Sep 11, 2021
@codecov
Copy link

codecov bot commented Sep 11, 2021

Codecov Report

Merging #905 (e8eb9e3) into master (d462655) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head e8eb9e3 differs from pull request most recent head aee31f3. Consider uploading reports for the commit aee31f3 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #905      +/-   ##
============================================
- Coverage     47.67%   47.66%   -0.01%     
+ Complexity     3391     3389       -2     
============================================
  Files           421      421              
  Lines         19976    19974       -2     
  Branches       2798     2798              
============================================
- Hits           9523     9521       -2     
  Misses         9396     9396              
  Partials       1057     1057              
Impacted Files Coverage Δ
...lipse/jkube/maven/plugin/mojo/develop/LogMojo.java 100.00% <ø> (ø)
...e/jkube/enricher/generic/ProjectLabelEnricher.java 58.22% <0.00%> (-0.53%) ⬇️
...n/java/org/eclipse/jkube/quarkus/QuarkusUtils.java 90.76% <0.00%> (-0.28%) ⬇️
...ube/enricher/generic/VolumePermissionEnricher.java 77.90% <0.00%> (-0.26%) ⬇️
...ipse/jkube/quarkus/generator/QuarkusGenerator.java 97.56% <0.00%> (+0.06%) ⬆️
...va/org/eclipse/jkube/kit/common/util/FileUtil.java 64.36% <0.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d462655...aee31f3. Read the comment docs.

@rohanKanojia
Copy link
Member

Could you please rebase your PR against master?

@yraydhitya yraydhitya force-pushed the issue887-maven-plugin-log-xml-configuration branch from 5c328fd to 083215b Compare September 19, 2021 12:57
@yraydhitya
Copy link
Contributor Author

Could you please rebase your PR against master?

Rebased.

@yraydhitya yraydhitya force-pushed the issue887-maven-plugin-log-xml-configuration branch from e8eb9e3 to aee31f3 Compare September 25, 2021 06:53
Signed-off-by: Raydhitya Yoseph <raydhitya.yoseph@gmail.com>
@manusa manusa force-pushed the issue887-maven-plugin-log-xml-configuration branch from aee31f3 to c362232 Compare October 7, 2021 03:13
@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa added this to the 1.5.0 milestone Oct 7, 2021
@manusa manusa merged commit 21ddf9f into eclipse-jkube:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LogMojo: Change access modifiers to protected for use in XML configuration
3 participants