-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #877: LogMojo: Change access modifiers to protected for use in XML configuration #905
Fix #877: LogMojo: Change access modifiers to protected for use in XML configuration #905
Conversation
Codecov Report
@@ Coverage Diff @@
## master #905 +/- ##
============================================
- Coverage 47.67% 47.66% -0.01%
+ Complexity 3391 3389 -2
============================================
Files 421 421
Lines 19976 19974 -2
Branches 2798 2798
============================================
- Hits 9523 9521 -2
Misses 9396 9396
Partials 1057 1057
Continue to review full report at Codecov.
|
kubernetes-maven-plugin/doc/src/main/asciidoc/inc/goals/develop/_jkube-log.adoc
Show resolved
Hide resolved
Could you please rebase your PR against master? |
5c328fd
to
083215b
Compare
Rebased. |
kubernetes-maven-plugin/doc/src/main/asciidoc/inc/goals/develop/_jkube-log.adoc
Outdated
Show resolved
Hide resolved
kubernetes-maven-plugin/doc/src/main/asciidoc/inc/goals/develop/_jkube-log.adoc
Outdated
Show resolved
Hide resolved
e8eb9e3
to
aee31f3
Compare
Signed-off-by: Raydhitya Yoseph <raydhitya.yoseph@gmail.com>
aee31f3
to
c362232
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
Description
Fixes #877
Type of change
test, version modification, documentation, etc.)
Checklist