%g should be resolved to namespace in OpenShift Maven Plugin
#910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now `%g` placeholder which corresponds to default image user picks `jkube.image.user` property first, if not then project groupId. Due to a typo in ResourceMojo for DOCKER_IMAGE_USER property, wrong property was being set in mojo. Relates to eclipse-jkube#904 Signed-off-by: Rohan Kumar <rohaan@redhat.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #910 +/- ##
=========================================
Coverage 47.46% 47.46%
- Complexity 3381 3384 +3
=========================================
Files 421 421
Lines 19974 19974
Branches 2798 2798
=========================================
Hits 9480 9480
- Misses 9447 9448 +1
+ Partials 1047 1046 -1
Continue to review full report at Codecov.
|
2 tasks
manusa
approved these changes
Sep 15, 2021
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Sep 15, 2021
This property was wrongly named in ResourceMojo, for maven plugins this got fixed in eclipse-jkube#910. Fix property name in OpenShiftResourceTask as well Signed-off-by: Rohan Kumar <rohaan@redhat.com>
12 tasks
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Sep 16, 2021
…sourceTask This property was wrongly named in ResourceMojo, for maven plugins this got fixed in eclipse-jkube#910 and later refactored to use static constant from ImageNameFormatter. Use same static constant in OpenShiftResourceTask Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Sep 17, 2021
…sourceTask This property was wrongly named in ResourceMojo, for maven plugins this got fixed in eclipse-jkube#910 and later refactored to use static constant from ImageNameFormatter. Use same static constant in OpenShiftResourceTask Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa
pushed a commit
that referenced
this pull request
Sep 17, 2021
…sourceTask This property was wrongly named in ResourceMojo, for maven plugins this got fixed in #910 and later refactored to use static constant from ImageNameFormatter. Use same static constant in OpenShiftResourceTask Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa
pushed a commit
that referenced
this pull request
Oct 11, 2021
…sourceTask This property was wrongly named in ResourceMojo, for maven plugins this got fixed in #910 and later refactored to use static constant from ImageNameFormatter. Use same static constant in OpenShiftResourceTask Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa
pushed a commit
that referenced
this pull request
Oct 19, 2021
…sourceTask This property was wrongly named in ResourceMojo, for maven plugins this got fixed in #910 and later refactored to use static constant from ImageNameFormatter. Use same static constant in OpenShiftResourceTask Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now
%gplaceholder which corresponds to default image user picksjkube.image.userproperty first, if not then project groupId.Due to a typo in ResourceMojo for DOCKER_IMAGE_USER property, wrong
property was being set in mojo.
Changes regarding changing access modifiers of some fields in ResourceMojo are only done
in order to be able to have them available in OpenShiftResourceMojoTest
Relates to #904
Signed-off-by: Rohan Kumar rohaan@redhat.com
Type of change
test, version modification, documentation, etc.)
Checklist