Emit onUpdate
event on DocumentBuilder#build
#1190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1188.
The global scope cache only gets cleared on
DocumentBuilder#update
, which works well in the language server case. However, in the CLI case, it is recommended to usebuild
instead, which doesn't call the listeners registered viaDocumentBuilder#onUpdate
.This results in incorrectly linked references, as the global scope hasn't been updated. This change also calls the update listeners on
build
, while also allowing the update listener to be potentially promises.