Fix async parser implementation #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lotes
reviewed
Feb 28, 2024
Lotes
reviewed
Feb 28, 2024
montymxb
approved these changes
Feb 28, 2024
sailingKieler
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Just wording improvement, and I agree with @Lotes, otherwise it's great! 🚀
msujew
force-pushed
the
msujew/fix-async-parser
branch
from
491fb70
to
8120014
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation has a few issues in the hydrator, especially related to CST transmission. This change improves on these issues and adds tests to ensure that the CST is correctly transmitted across worker threads.