Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented SignatureHelp LSP service #612

Merged
merged 13 commits into from
Aug 9, 2022
Merged

Conversation

gfontorbe
Copy link
Contributor

This PR provides the backbone to enable the implementation of SignatureHelp service.

The LSP service is to be implemented on a per-language basis.

@gfontorbe gfontorbe added the LSP Language Server Protocol integration label Jul 29, 2022
@gfontorbe gfontorbe requested a review from msujew July 29, 2022 11:28
packages/langium/src/services.ts Outdated Show resolved Hide resolved
packages/langium/src/lsp/signature-help-provider.ts Outdated Show resolved Hide resolved
packages/langium/src/lsp/language-server.ts Outdated Show resolved Hide resolved
gfontorbe and others added 3 commits August 2, 2022 17:33
Co-authored-by: Mark Sujew <mark.sujew@typefox.io>
Co-authored-by: Mark Sujew <mark.sujew@typefox.io>
packages/langium/src/test/langium-test.ts Outdated Show resolved Hide resolved
packages/langium/test/lsp/go-to-type.test.ts Outdated Show resolved Hide resolved
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the changes look good to me 👍

Co-authored-by: Mark Sujew <mark.sujew@typefox.io>
@msujew
Copy link
Member

msujew commented Aug 8, 2022

@gfontorbe Please rebase on the latest main. Merging your other PR has created conflicts.

@gfontorbe gfontorbe merged commit 768e51b into main Aug 9, 2022
@gfontorbe gfontorbe deleted the gfontorbe/signatureHelp branch August 9, 2022 08:26
@spoenemann spoenemann added this to the v0.5.0 milestone Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LSP Language Server Protocol integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants