Adds Monarch Grammar File Generation #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montymxb
changed the title
msujew
reviewed
Aug 5, 2022
packages/langium-cli/src/generator/highlighting/monarch-generator.ts
Outdated
Show resolved
Hide resolved
packages/langium-cli/src/generator/highlighting/monarch-generator.ts
Outdated
Show resolved
Hide resolved
packages/langium-cli/src/generator/highlighting/monarch-generator.ts
Outdated
Show resolved
Hide resolved
packages/langium-cli/src/generator/highlighting/monarch-generator.ts
Outdated
Show resolved
Hide resolved
packages/langium-cli/src/generator/highlighting/monarch-generator.ts
Outdated
Show resolved
Hide resolved
packages/langium-cli/src/generator/highlighting/monarch-generator.ts
Outdated
Show resolved
Hide resolved
|
Thanks for the feedback @msujew . Next commit of changes should be up sometime later tomorrow. |
|
New changes are up 👍 |
spoenemann
reviewed
Aug 11, 2022
packages/langium-cli/src/generator/highlighting/textmate-generator.ts
Outdated
Show resolved
Hide resolved
msujew
reviewed
Aug 24, 2022
packages/langium-cli/src/generator/highlighting/monarch-generator.ts
Outdated
Show resolved
Hide resolved
|
Last review points added in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #582 by adding an option to generate a Monarch grammar file. This supplements our existing generation for TextMate grammar files, so we can generate one, both, or neither of them as we choose.
As an example I've updated the statemachine example's
langium-configto construct a Monarch grammar, and I've added the resulting file.Currently I've been comparing the results by using Microsoft's Monarch Editor (playground), and it looks good.
The shows is marked as having quite a few errors in VSCode but the format should be ok when used in a Monaco instance. I haven't tried setting this up directly, but that would be the next step.