Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change type of CodeLensOptions.resolveProvider to Boolean #534

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Change type of CodeLensOptions.resolveProvider to Boolean #534

merged 1 commit into from
Mar 29, 2021

Conversation

pisv
Copy link
Contributor

@pisv pisv commented Mar 29, 2021

Fixes #533

@jonahgraham
Copy link
Contributor

LGTM.

@pisv
Copy link
Contributor Author

pisv commented Mar 29, 2021

Thanks for the review Jonah! I believe it's simple enough to be merged without delay, isn't it?

@jonahgraham
Copy link
Contributor

Thanks for the review Jonah! I believe it's simple enough to be merged without delay, isn't it?

Yes

@pisv pisv merged commit 24bfd20 into eclipse-lsp4j:master Mar 29, 2021
@pisv pisv deleted the GH-533 branch March 29, 2021 17:48
@pisv
Copy link
Contributor Author

pisv commented Mar 29, 2021

Done. Thanks @KamasamaK for the review and approval.

@jonahgraham jonahgraham added this to the v0.12.0 milestone Apr 2, 2021
@jonahgraham jonahgraham mentioned this pull request Apr 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KamasamaK KamasamaK KamasamaK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.

CodeLensOptions.resolveProvider should be Boolean
3 participants
@pisv @jonahgraham @KamasamaK