NPE in AbstractJavaProjectConfigurator

[snjeza]

Steps to reproduce:

• install Eclipse 4.32M1 and m2e - https://download.eclipse.org/eclipse/downloads/drops4/S-4.32M1-202404061800/
• try to import https://github.com/eclipse-m2e/m2e-core/tree/master/org.eclipse.m2e.jdt.tests/projects/compilerSettings

m2e throws NPE at AbstractJavaProjectConfigurator.java, line 128, and the project isn't configured correctly.
The issue is caused by eclipse-equinox/equinox#571

[rgrunber]

I'm also able to reproduce. Project import completely fails now.

Version: 2024-06 (4.32)
Build id: I20240406-1800

with m2e from https://download.eclipse.org/technology/m2e/releases/latest/

As @snjeza points out, at

m2e-core/org.eclipse.m2e.jdt/src/org/eclipse/m2e/jdt/internal/AbstractJavaProjectConfigurator.java

Line 128 in 2756a6f

var compliance = ee.getComplianceOptions().get(JavaCore.COMPILER_COMPLIANCE);

(static block) , getComplianceOptions() is called on the JRE-1.1 profile that is declared at https://github.com/eclipse-jdt/eclipse.jdt.debug/blob/7c57761f182f30e385b7c980f1f80390d75eadc2/org.eclipse.jdt.launching/plugin.xml#L281-L284 .

At https://github.com/eclipse-jdt/eclipse.jdt.debug/blob/master/org.eclipse.jdt.launching/launching/org/eclipse/jdt/internal/launching/environments/ExecutionEnvironment.java#L436 , since no path file is defined the code delegates to OSGI, and that profile is gone. It returns null and the NPE from the getComplianceOptions() chained call triggers an ExceptioninitializationError.

I've only seen this with m2e, but pretty much any client calling getComplianceOptions() on a JRE-1.1 EE provided by JDT Debug ( JavaRuntime.getExecutionEnvironmentsManager().getExecutionEnvironments() ) could run into this now.

Once jdt.debug removes the profile on their end, it might be nice to also guard against this failure in the static block.

[HannesWell]

Thanks for this report. I also noticed this recently.

Once jdt.debug removes the profile on their end, it might be nice to also guard against this failure in the static block.

Shouldn't this error vanish completely automatically once eclipse-jdt/eclipse.jdt.debug#425 is available? Then JavaRuntime.getExecutionEnvironmentsManager().getExecutionEnvironments() simply shouldn't return a JRE-1.1 EE.
But then the JRE element can probably be removed from:

m2e-core/org.eclipse.m2e.jdt/src/org/eclipse/m2e/jdt/internal/AbstractJavaProjectConfigurator.java

Line 112 in 2756a6f

Set<String> supportedExecutionEnvironmentTypes = Set.of("JRE", "J2SE", "JavaSE");

[rgrunber]

Yes, the error will be completely fixed by the JDT Debug PR. I guess the only concern for m2e is that static blocks like

m2e-core/org.eclipse.m2e.jdt/src/org/eclipse/m2e/jdt/internal/AbstractJavaProjectConfigurator.java

Line 111 in 2756a6f

static {

that do a fair amount of computation can be a real pain when they fail. After the ExceptionInitializationError, they'll just fail with ClassNotFoundException.

Update: Even simpler, getComplianceOptions().get(...) should be checked because getComplianceOptions() can be null.

[sratz]

I guess the only concern for m2e is that static blocks like

m2e-core/org.eclipse.m2e.jdt/src/org/eclipse/m2e/jdt/internal/AbstractJavaProjectConfigurator.java

Line 111 in 2756a6f

static {

that do a fair amount of computation can be a real pain when they fail. After the ExceptionInitializationError, they'll just fail with ClassNotFoundException.

Indeed, I was hit by the same problem (just got a Project configurator "org.eclipse.m2e.jdt.javaConfigurator" required by plugin execution "org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (execution: default-compile, phase: compile)" is not available. To enable full functionality, install the project configurator and run Maven->Update Project Configuration. problem markerwith no log/stack whatsoever). Debugging pointed me to this very issue.

Update: Even simpler, getComplianceOptions().get(...) should be checked because getComplianceOptions() can be null.

#1736.