Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TP] Update to WWD 1.3.4 and LSP4E 0.26 #1753

Merged
merged 2 commits into from May 9, 2024

Conversation

HannesWell
Copy link
Contributor

Fixes #1751

Copy link

github-actions bot commented May 7, 2024

Test Results

665 tests  ±0   652 ✅  - 2   9m 18s ⏱️ +5s
107 suites ±0    10 💤 ±0 
107 files   ±0     2 ❌ +1   1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit 5c3d907. ± Comparison against base commit d368f6a.

♻️ This comment has been updated with latest results.

@HannesWell
Copy link
Contributor Author

Build fails with

Error:  Cannot resolve target definition:
Error:    Software being installed: org.eclipse.wildwebdeveloper.xml.feature.feature.group 1.3.2.202403191205
Error:    Missing requirement: org.eclipse.lsp4e 0.18.7.202404031149 requires 'osgi.bundle; org.eclipse.mylyn.wikitext 3.0.40' but it could not be found
Error:    Missing requirement: org.eclipse.lsp4e 0.18.8.202404261614 requires 'osgi.bundle; org.eclipse.mylyn.wikitext 3.0.40' but it could not be found
Error:    Cannot satisfy dependency: org.eclipse.wildwebdeveloper.xml 1.3.2.202403191205 depends on: osgi.bundle; org.eclipse.lsp4e 0.16.0
Error:    Cannot satisfy dependency: org.eclipse.wildwebdeveloper.xml.feature.feature.group 1.3.2.202403191205 depends on: org.eclipse.equinox.p2.iu; org.eclipse.wildwebdeveloper.xml [1.3.2.202403191205,1.3.2.202403191205]

Altough org.eclipse.mylyn.wikitext is available, in version 3.0.44.202211082139 but I don't see a fixed range.
Furthermore I wonder why there are two versions of lsp4e?

@HannesWell HannesWell force-pushed the update-dependencies branch 2 times, most recently from dc21b64 to ed10b81 Compare May 8, 2024 20:48
@HannesWell
Copy link
Contributor Author

Altough I have changed the pipelines with use Java-21 the build fails as follows:

[INFO] Resolving file:${project_loc:/m2e-core}/target-platform/m2e-runtimes.target
[INFO] Reading target platform file:/home/jenkins/agent/workspace/m2e_PR-1753/target-platform/m2e-runtimes.target
[INFO] Performing subquery
[ERROR] org.eclipse.wildwebdeveloper.xml 1.3.2.202403191205 requires Execution Environment that matches (&(osgi.ee=JavaSE)(version=21)) but the current resolution context uses [a.jre.javase 17.0.0]
[ERROR] Cannot resolve target definition:
[ERROR]   Software being installed: org.eclipse.wildwebdeveloper.xml.feature.feature.group 1.3.2.202403191205
[ERROR]   Missing requirement: org.eclipse.wildwebdeveloper.xml 1.3.2.202403191205 requires 'osgi.ee; (&(osgi.ee=JavaSE)(version=21))' but it could not be found
[ERROR]   Cannot satisfy dependency: org.eclipse.wildwebdeveloper.xml.feature.feature.group 1.3.2.202403191205 depends on: org.eclipse.equinox.p2.iu; org.eclipse.wildwebdeveloper.xml 

@laeubi or @merks any immediate idea? I haven't yet investigated it in great detail.

@akurtakov
Copy link
Contributor

You have to change targetJRE to Java 21 in target file too.

@merks
Copy link
Contributor

merks commented May 9, 2024

This worked for me:

image

Configure the Tycho-surefire and tycho-compiler plug-ins to still use a
Java-17 JDK to run tests respectively build m2e projects.
@HannesWell
Copy link
Contributor Author

You have to change targetJRE to Java 21 in target file too.

🤦🏽‍♂️Obviously. Thanks, that worked locally.

This worked for me:

Thanks for that hint, but this is not set in m2e's pom.xml.

@HannesWell
Copy link
Contributor Author

@laeubi any objections against building with 21? Actually we have no other option.

@akurtakov
Copy link
Contributor

akurtakov commented May 9, 2024

IMO even M2E should move to target Java 21 now.

@HannesWell
Copy link
Contributor Author

The build succeeded now and the test failures are unrelated, so lets submit this.

IMO even M2E should move to target Java 21 now.

In general I have no objects about that, but I currently don't have the time to change all the configurations.
Therefore my suggestion is to such change in the beginning of the next development cycle.

@HannesWell HannesWell merged commit d0c5fe2 into eclipse-m2e:master May 9, 2024
4 of 7 checks passed
@HannesWell HannesWell deleted the update-dependencies branch May 9, 2024 12:12
@laeubi
Copy link
Member

laeubi commented May 9, 2024

IMO even M2E should move to target Java 21 now.

This will require that EPPs (and consequently Eclipse SDK) move to Java 21 I just wanted to mention it.

@akurtakov
Copy link
Contributor

IMO even M2E should move to target Java 21 now.

This will require that EPPs (and consequently Eclipse SDK) move to Java 21 I just wanted to mention it.

EPPs already made the move - eclipse-packaging/packages#130

@HannesWell
Copy link
Contributor Author

IMO even M2E should move to target Java 21 now.

This will require that EPPs (and consequently Eclipse SDK) move to Java 21 I just wanted to mention it.

EPPs already made the move - eclipse-packaging/packages#130

Yes and the SDK also doesn't have to move.
When we switched from 11 to 17 m2e also followed one of the editor dependencies and the SDK followed one or two releases later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please don't transitively reference a p2 repository with abitrary JustJ JRE versions
4 participants