Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update require Java 21 #130

Closed
merks opened this issue Apr 3, 2024 · 2 comments
Closed

Update require Java 21 #130

merks opened this issue Apr 3, 2024 · 2 comments

Comments

@merks
Copy link
Contributor

merks commented Apr 3, 2024

@jonahgraham

I will coordinate the necessary changes with the JustJ changes.

Note that the first 2024-06 M1 content build using the restructured infrastructure was successful:

https://download.eclipse.org/justj/?file=technology/epp/staging

BTW, I've never seen this before:

image

I assume this should be updated to 21 too.
@jonahgraham
Copy link
Contributor

<vmArgs>

Yes, this needs updating to fail early if wrong Eclipse is present.

<vm> section
I assume so - they were updated for all previous updates and correspond to this part of the UI:

image

However I don't know if there is a purpose for the build. The Platform's product file does not have this info. PDE uses this section to populate the the launch configuration, so keeping it in doesn't seem like a bad idea:

image

For reasons of probable simple oversight DSL still has Java 11 in that section. It should probably be synchronized too:

packages/packages/org.eclipse.epp.package.dsl.product/epp.product

Lines 59 to 61 in 4292240

<linux include="false">org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-11</linux>
<macos include="false">org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-11</macos>
<windows include="false">org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-11</windows>

merks added a commit to eclipse-justj/justj that referenced this issue Apr 4, 2024
@merks
Update JustJ EPP to Java 21 as needed by the packages for 2024-06
f3d6c1e 
eclipse-packaging/packages#130
merks added a commit to merks/packages that referenced this issue Apr 4, 2024
@merks
Update to Java 21
e380a8f 
- Update github actions and Jenkins to use Java 21 for the build itself.
- Update all BREEs and .classpath files to Java 21.
- Update all product's specific -Dosgi.requiredJavaVersion=21.
- Update all product <vm> JRE_CONTAINERs to JavaSE-21.
- Invoke the aggregator with Java 21.
- Update the setp to configure a Java 21 JRE and populate JustJ Java 21
into the target platform and in the string substitutions.

eclipse-packaging#130
@merks merks mentioned this issue Apr 4, 2024
Merged
merks added a commit to merks/packages that referenced this issue Apr 4, 2024
@merks
Update to Java 21
10fccd4 
- Update github actions and Jenkins to use Java 21 for the build itself.
- Update all BREEs and .classpath files to Java 21.
- Update all product's specific -Dosgi.requiredJavaVersion=21.
- Update all product <vm> JRE_CONTAINERs to JavaSE-21.
- Invoke the aggregator with Java 21.
- Update the setp to configure a Java 21 JRE and populate JustJ Java 21
into the target platform and in the string substitutions.
- Eliminate avoidable warnings in org.eclipse.epp.package.common.

eclipse-packaging#130
merks added a commit that referenced this issue Apr 4, 2024
@merks
Update to Java 21
cbf9062 
- Update github actions and Jenkins to use Java 21 for the build itself.
- Update all BREEs and .classpath files to Java 21.
- Update all product's specific -Dosgi.requiredJavaVersion=21.
- Update all product <vm> JRE_CONTAINERs to JavaSE-21.
- Invoke the aggregator with Java 21.
- Update the setp to configure a Java 21 JRE and populate JustJ Java 21
into the target platform and in the string substitutions.
- Eliminate avoidable warnings in org.eclipse.epp.package.common.

#130
merks added a commit to merks/packages that referenced this issue Apr 4, 2024
@merks
Properly update Jenkinsfile to use Temurin Java 21.
04dcefe 
eclipse-packaging#130
@merks merks mentioned this issue Apr 4, 2024
Merged
merks added a commit that referenced this issue Apr 4, 2024
@merks
Properly update Jenkinsfile to use Temurin Java 21.
3dbc0c8 
#130
@merks
Copy link
Contributor Author

merks commented Apr 4, 2024

The latest staging build includes all the support for Java 21:

https://download.eclipse.org/justj/?file=technology/epp/staging

@merks merks closed this as completed Apr 4, 2024
@akurtakov akurtakov mentioned this issue May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@merks @jonahgraham